From: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 03/11] dt-bindings: usb: mtk-xhci: add compatible for mt8195
Date: Thu, 19 Aug 2021 11:36:01 +0000 [thread overview]
Message-ID: <8166fa917d6df5002617c5fb5d614e5ff5bd6af6.camel@mediatek.com> (raw)
In-Reply-To: <CAL_JsqKjjPqArmhoXuYrk+1C-vXFSKNA_gxtOfLFsGTGBq20aQ@mail.gmail.com>
On Wed, 2021-08-18 at 09:20 -0500, Rob Herring wrote:
> On Wed, Aug 11, 2021 at 3:02 AM Chunfeng Yun (云春峰)
> <Chunfeng.Yun@mediatek.com> wrote:
> >
> > On Fri, 2021-08-06 at 14:43 -0600, Rob Herring wrote:
> > > On Fri, Jul 30, 2021 at 04:49:54PM +0800, Chunfeng Yun wrote:
> > > > There are 4 USB controllers on MT8195, the controllers
> > > > (IP1~IP3,
> > > > exclude IP0) have a wrong default SOF/ITP interval which is
> > > > calculated from the frame counter clock 24Mhz by default, but
> > > > in fact, the frame counter clock is 48Mhz, so we should set
> > > > the accurate interval according to 48Mhz. Here add a new
> > > > compatible
> > > > for MT8195, it's also supported in driver. But the first
> > > > controller
> > > > (IP0) has no such issue, we prefer to use generic compatible,
> > > > e.g. mt8192's compatible.
> > >
> > > That only works until you find some 8195 bug common to all
> > > instances.
> >
> > It's also OK for IP0 to use mt8195's compatible, these setting
> > value is
> > the same as IP0's default value, use mt8192's may avoid these dummy
> > setting.
>
> I still don't understand. By use mt8192's compatible, that means you
> have for IP0:
>
> compatible = "mediatek,mt8192-xhci", "mediatek,mtk-xhci";
>
> And for the rest:
> compatible = "mediatek,mt8195-xhci", "mediatek,mtk-xhci";
No, use "mediatek,mt8195-xhci" is also ok for IP0.
Seems need modify commit log and remove last sentence to avoid
misunderstanding.
Thanks
>
> If there's a 8195 quirk you need to work around, then you can't on
> IP0. You need to be able to address quirks in the future without
> changing the DTB. That is why we require SoC specific compatibles
> even
> when IP blocks are 'the same'.
>
> Rob
next prev parent reply other threads:[~2021-08-19 11:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 8:49 [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Chunfeng Yun
2021-07-30 8:49 ` [PATCH 02/11] dt-bindings: usb: mtk-xhci: add optional property to disable usb2 ports Chunfeng Yun
2021-08-06 20:41 ` Rob Herring
2021-08-11 8:12 ` Chunfeng Yun (云春峰)
2021-07-30 8:49 ` [PATCH 03/11] dt-bindings: usb: mtk-xhci: add compatible for mt8195 Chunfeng Yun
2021-08-06 20:43 ` Rob Herring
2021-08-11 8:02 ` Chunfeng Yun (云春峰)
2021-08-18 14:20 ` Rob Herring
2021-08-19 11:36 ` Chunfeng Yun (云春峰) [this message]
2021-07-30 8:49 ` [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd Chunfeng Yun
2021-08-13 5:26 ` Ikjoon Jang
2021-07-30 8:49 ` [PATCH 05/11] usb: xhci-mtk: add support 'tpl-support' Chunfeng Yun
2021-07-30 8:49 ` [PATCH 06/11] usb: xhci-mtk: support option to disable usb2 ports Chunfeng Yun
2021-07-30 8:49 ` [PATCH 07/11] usb: xhci-mtk: fix issue of out-of-bounds array access Chunfeng Yun
2021-07-30 8:49 ` [PATCH 08/11] usb: xhci-mtk: update fs bus bandwidth by bw_budget_table Chunfeng Yun
2021-08-03 6:05 ` Ikjoon Jang
2021-08-04 5:19 ` Chunfeng Yun
2021-08-04 14:06 ` Ikjoon Jang
2021-08-10 1:45 ` Chunfeng Yun (云春峰)
2021-07-30 8:50 ` [PATCH 09/11] usb: xhci-mtk: check boundary before check tt Chunfeng Yun
2021-08-09 7:32 ` Ikjoon Jang
2021-08-11 8:18 ` Chunfeng Yun (云春峰)
2021-07-30 8:50 ` [PATCH 10/11] usb: xhci-mtk: add a member of num_esit Chunfeng Yun
2021-07-30 8:50 ` [PATCH 11/11] usb: xhci-mtk: modify the SOF/ITP interval for mt8195 Chunfeng Yun
2021-08-06 20:37 ` [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Rob Herring
2021-08-11 7:54 ` Chunfeng Yun (云春峰)
2021-08-12 2:28 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8166fa917d6df5002617c5fb5d614e5ff5bd6af6.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=Eddie.Hung@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).