From: shuah <shuah@kernel.org>
To: Colin King <colin.king@canonical.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] usbip: clean up an indentation issue
Date: Fri, 27 Sep 2019 10:05:24 -0600 [thread overview]
Message-ID: <824cf4f0-572b-9b60-e93c-83c1be0df181@kernel.org> (raw)
In-Reply-To: <20190927092000.19373-1-colin.king@canonical.com>
On 9/27/19 3:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a return statement that is indented incorrectly, fix this.
Please include the warn you are fixing in the commit log
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/usbip/stub_tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
> index 36010a82b359..b1c2f6781cb3 100644
> --- a/drivers/usb/usbip/stub_tx.c
> +++ b/drivers/usb/usbip/stub_tx.c
> @@ -291,7 +291,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
> kfree(iov);
> usbip_event_add(&sdev->ud,
> SDEV_EVENT_ERROR_TCP);
> - return -1;
> + return -1;
> }
> }
>
>
thanks,
-- Shuah
prev parent reply other threads:[~2019-09-27 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 9:20 [PATCH] usbip: clean up an indentation issue Colin King
2019-09-27 16:05 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824cf4f0-572b-9b60-e93c-83c1be0df181@kernel.org \
--to=shuah@kernel.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).