* [PATCH] usbip: clean up an indentation issue
@ 2019-09-27 9:20 Colin King
2019-09-27 16:05 ` shuah
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-09-27 9:20 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a return statement that is indented incorrectly, fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/usbip/stub_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
index 36010a82b359..b1c2f6781cb3 100644
--- a/drivers/usb/usbip/stub_tx.c
+++ b/drivers/usb/usbip/stub_tx.c
@@ -291,7 +291,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
kfree(iov);
usbip_event_add(&sdev->ud,
SDEV_EVENT_ERROR_TCP);
- return -1;
+ return -1;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbip: clean up an indentation issue
2019-09-27 9:20 [PATCH] usbip: clean up an indentation issue Colin King
@ 2019-09-27 16:05 ` shuah
0 siblings, 0 replies; 2+ messages in thread
From: shuah @ 2019-09-27 16:05 UTC (permalink / raw)
To: Colin King, Valentina Manea, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel, shuah
On 9/27/19 3:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a return statement that is indented incorrectly, fix this.
Please include the warn you are fixing in the commit log
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/usbip/stub_tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/stub_tx.c b/drivers/usb/usbip/stub_tx.c
> index 36010a82b359..b1c2f6781cb3 100644
> --- a/drivers/usb/usbip/stub_tx.c
> +++ b/drivers/usb/usbip/stub_tx.c
> @@ -291,7 +291,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
> kfree(iov);
> usbip_event_add(&sdev->ud,
> SDEV_EVENT_ERROR_TCP);
> - return -1;
> + return -1;
> }
> }
>
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-27 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 9:20 [PATCH] usbip: clean up an indentation issue Colin King
2019-09-27 16:05 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).