From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling
Date: Tue, 18 Aug 2020 09:56:41 +0300 [thread overview]
Message-ID: <87364kzbkm.fsf@kernel.org> (raw)
In-Reply-To: <988d2d58-59f6-3d1e-bc66-ab424cc0fff4@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Hi Felipe,
>
> Thinh Nguyen wrote:
>> This series fixes a couple of driver issues handling ClearFeature(halt)
>> request:
>>
>> 1) A function driver often uses set_halt() to reject a class driver protocol
>> command. After set_halt(), the endpoint will be stalled. It can queue new
>> requests while the endpoint is stalled. However, dwc3 currently drops those
>> requests after CLEAR_STALL. The driver should only drop started requests. Keep
>> the pending requests in the pending list to resume and process them after the
>> host issues ClearFeature(Halt) to the endpoint.
>>
>> 2) DWC3 should issue CLEAR_STALL command _after_ END_TRANSFER command completes.
>>
>>
>> Thinh Nguyen (3):
>> usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
>> usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command
>
> Since you're picking the fix patches for RC cycle, can you pick up these
> 2 patches of this series also? We can leave the refactoring patch in
> this series for v5.10.
just to be sure: you did run these through usbcv and usb3 compliance
suite, right? Which gadget drivers did you use?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-08-18 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 23:28 [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling Thinh Nguyen
2020-07-30 23:28 ` [PATCH 1/3] usb: dwc3: gadget: Resume pending requests after CLEAR_STALL Thinh Nguyen
2020-07-30 23:28 ` [PATCH 2/3] usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command Thinh Nguyen
2020-07-30 23:29 ` [PATCH 3/3] usb: dwc3: gadget: Refactor ep command completion Thinh Nguyen
2020-08-17 18:06 ` [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling Thinh Nguyen
2020-08-18 6:56 ` Felipe Balbi [this message]
2020-08-18 21:40 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87364kzbkm.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).