linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling
Date: Mon, 17 Aug 2020 18:06:27 +0000	[thread overview]
Message-ID: <988d2d58-59f6-3d1e-bc66-ab424cc0fff4@synopsys.com> (raw)
In-Reply-To: <cover.1596151437.git.thinhn@synopsys.com>

Hi Felipe,

Thinh Nguyen wrote:
> This series fixes a couple of driver issues handling ClearFeature(halt)
> request:
>
> 1) A function driver often uses set_halt() to reject a class driver protocol
> command. After set_halt(), the endpoint will be stalled. It can queue new
> requests while the endpoint is stalled. However, dwc3 currently drops those
> requests after CLEAR_STALL. The driver should only drop started requests. Keep
> the pending requests in the pending list to resume and process them after the
> host issues ClearFeature(Halt) to the endpoint.
>
> 2) DWC3 should issue CLEAR_STALL command _after_ END_TRANSFER command completes.
>
>
> Thinh Nguyen (3):
>   usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
>   usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command

Since you're picking the fix patches for RC cycle, can you pick up these
2 patches of this series also? We can leave the refactoring patch in
this series for v5.10.

Thanks,
Thinh


>   usb: dwc3: gadget: Refactor ep command completion
>
>  drivers/usb/dwc3/core.h   |  1 +
>  drivers/usb/dwc3/ep0.c    | 16 +++++++++
>  drivers/usb/dwc3/gadget.c | 85 +++++++++++++++++++++++++++++++----------------
>  drivers/usb/dwc3/gadget.h |  1 +
>  4 files changed, 75 insertions(+), 28 deletions(-)
>
>
> base-commit: e3ee0e740c3887d2293e8d54a8707218d70d86ca


  parent reply	other threads:[~2020-08-17 18:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 23:28 [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling Thinh Nguyen
2020-07-30 23:28 ` [PATCH 1/3] usb: dwc3: gadget: Resume pending requests after CLEAR_STALL Thinh Nguyen
2020-07-30 23:28 ` [PATCH 2/3] usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command Thinh Nguyen
2020-07-30 23:29 ` [PATCH 3/3] usb: dwc3: gadget: Refactor ep command completion Thinh Nguyen
2020-08-17 18:06 ` Thinh Nguyen [this message]
2020-08-18  6:56   ` [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling Felipe Balbi
2020-08-18 21:40     ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=988d2d58-59f6-3d1e-bc66-ab424cc0fff4@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).