linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Sandeep Maheswaram <sanm@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Pratham Pratap <prathampratap@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Doug Anderson <dianders@chromium.org>
Subject: Re: Regarding usb dwc3 core shutdown callback
Date: Mon, 30 Aug 2021 07:45:57 +0300	[thread overview]
Message-ID: <87r1ebczei.fsf@kernel.org> (raw)
In-Reply-To: <7a6bf94b-91cd-15d5-dd9c-798e7a927727@codeaurora.org>


Sandeep Maheswaram <sanm@codeaurora.org> writes:

> Hi,
>
> On 8/26/2021 4:13 PM, Felipe Balbi wrote:
>> Hi,
>>
>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>> (why isn't this email plain/text? Content Type was set to multipart
>>>> alternative, please configure your email client correctly :-)
>>>>
>>>> While at that, also make sure to break lines at 80-columns)
>>>>
>>>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>>> Hi,
>>>>>
>>>>> Earlier I have posted the patch for usb dwc3 core shutdown callback
>>>>>
>>>>> https://lore.kernel.org/linux-arm-msm/1618380209-20114-1-git-send-email-sanm@codeaurora.org/
>>>>>
>>>>> and it was reverted due to issues.
>>>> Right, as should be expected when we find regressions
>>>>
>>>>> https://lore.kernel.org/linux-usb/20210603151742.298243-1-alexandru.elisei@arm.com/
>>>>>
>>>>> As we already have shutdown callback in xhci plat driver where we halt
>>>>> the controller, so there will be no transactions with usb devices.
>>>>>
>>>>> https://lore.kernel.org/linux-usb/20200306092328.41253-1-ran.wang_1@nxp.com/
>>>>>
>>>>> So I think dwc3 core shutdown may not be required at least when we are
>>>>> using host mode. Let me know your opinion about this.
>>>> If that's the case, then sure. Please validate the condition, though,
>>>> and kindly report back on your findings
>>> I have enabled couple of logs in shutdown path and see no URBs
>>> enqueued after xhci shut down.
>>>
>>> Hope this is enough for validation . Please suggest if anything more I
>>> could do.
>> how about writing a little script to kexec into another kernel for a few
>> hundred iterations and make sure things still work after all that?
>
> Currently kexec is not supported on qcom devices.  Anything we can do
> apart from kexec?

Sure about that? I've been using kexec with 8150 for quite a while.

-- 
balbi

      reply	other threads:[~2021-08-30  4:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e34c8e16-6521-c6e4-f3ed-9d8520d4ece2@codeaurora.org>
2021-08-12  9:07 ` Felipe Balbi
2021-08-26  9:41   ` Sandeep Maheswaram
2021-08-26 10:43     ` Felipe Balbi
2021-08-30  4:18       ` Sandeep Maheswaram
2021-08-30  4:45         ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1ebczei.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jackp@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mka@chromium.org \
    --cc=prathampratap@codeaurora.org \
    --cc=sanm@codeaurora.org \
    --cc=swboyd@chromium.org \
    --subject='Re: Regarding usb dwc3 core shutdown callback' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).