* [PATCH] usb: cdns3: gadget: Remove unneeded variable ret
@ 2019-12-20 7:19 Xu Wang
2019-12-23 8:53 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2019-12-20 7:19 UTC (permalink / raw)
To: gregkh
Cc: pawell, balbi, peter.chen, rogerq, colin.king, linux-usb, linux-kernel
Remove unneeded variable ret used to store return value,just return 0.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/usb/cdns3/gadget.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 4c1e755..73b75a3 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -2389,7 +2389,6 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
struct cdns3_endpoint *priv_ep;
u32 bEndpointAddress;
struct usb_ep *ep;
- int ret = 0;
int val;
priv_dev->gadget_driver = NULL;
@@ -2413,7 +2412,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
writel(0, &priv_dev->regs->usb_ien);
writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
- return ret;
+ return 0;
}
static const struct usb_gadget_ops cdns3_gadget_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: cdns3: gadget: Remove unneeded variable ret
2019-12-20 7:19 [PATCH] usb: cdns3: gadget: Remove unneeded variable ret Xu Wang
@ 2019-12-23 8:53 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2019-12-23 8:53 UTC (permalink / raw)
To: Xu Wang, gregkh
Cc: pawell, balbi, peter.chen, colin.king, linux-usb, linux-kernel
On 20/12/2019 09:19, Xu Wang wrote:
> Remove unneeded variable ret used to store return value,just return 0.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/cdns3/gadget.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 4c1e755..73b75a3 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2389,7 +2389,6 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
> struct cdns3_endpoint *priv_ep;
> u32 bEndpointAddress;
> struct usb_ep *ep;
> - int ret = 0;
> int val;
>
> priv_dev->gadget_driver = NULL;
> @@ -2413,7 +2412,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
> writel(0, &priv_dev->regs->usb_ien);
> writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
>
> - return ret;
> + return 0;
> }
>
> static const struct usb_gadget_ops cdns3_gadget_ops = {
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-23 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 7:19 [PATCH] usb: cdns3: gadget: Remove unneeded variable ret Xu Wang
2019-12-23 8:53 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).