From: Peter Chen <peter.chen@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: RE: [PATCH v2 6/6] Revert "usb: udc: allow adding and removing the same gadget device"
Date: Tue, 18 Aug 2020 10:05:51 +0000 [thread overview]
Message-ID: <AM7PR04MB7157182367D7EEE2BDAD53318B5C0@AM7PR04MB7157.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200818093305.GA34785@kroah.com>
> >
> > diff --git a/drivers/usb/gadget/udc/core.c
> > b/drivers/usb/gadget/udc/core.c index 473e74088b1f..43351b0af569
> > 100644
> > --- a/drivers/usb/gadget/udc/core.c
> > +++ b/drivers/usb/gadget/udc/core.c
> > @@ -1386,7 +1386,6 @@ void usb_del_gadget_udc(struct usb_gadget
> > *gadget) {
> > usb_del_gadget(gadget);
> > usb_put_gadget(gadget);
> > - memset(&gadget->dev, 0x00, sizeof(gadget->dev));
>
> Shouldn't you do this patch earlier in the series, as the
> usb_put_gadget() call could have freed the memory that is being cleared here?
>
If I did it earlier, it would cause dwc3 break if people do 'git bisect', dwc3 issue is
fixed at patch 5.
Peter
> Otherwise, this series looks good, thanks for doing it.
>
> greg k-h
next prev parent reply other threads:[~2020-08-18 10:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 2:25 [PATCH v2 0/6] USB: UDC: Fix memory leaks by expanding the API Peter Chen
2020-08-10 2:25 ` [PATCH v2 1/6] USB: UDC: Expand device model API interface Peter Chen
2020-08-10 2:25 ` [PATCH v2 2/6] USB: UDC: net2280: Fix memory leaks Peter Chen
2020-08-10 2:25 ` [PATCH v2 3/6] USB: UDC: net2272: " Peter Chen
2020-08-10 2:25 ` [PATCH v2 4/6] usb: cdns3: gadget: fix possible memory leak Peter Chen
2020-08-10 2:25 ` [PATCH v2 5/6] usb: dwc3: allocate gadget structure dynamically Peter Chen
2020-08-10 2:25 ` [PATCH v2 6/6] Revert "usb: udc: allow adding and removing the same gadget device" Peter Chen
2020-08-18 9:33 ` Greg KH
2020-08-18 10:05 ` Peter Chen [this message]
2020-08-18 14:46 ` stern
2020-08-19 1:31 ` Peter Chen
2020-08-19 14:52 ` stern
2020-08-20 3:40 ` Peter Chen
2020-08-20 14:25 ` stern
2020-08-18 9:33 ` [PATCH v2 0/6] USB: UDC: Fix memory leaks by expanding the API Greg KH
2020-08-18 10:07 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR04MB7157182367D7EEE2BDAD53318B5C0@AM7PR04MB7157.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).