From: Doug Anderson <dianders@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Minas Harutyunyan" <hminas@synopsys.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Antti Seppälä" <a.seppala@gmail.com>,
"Boris ARZUR" <boris@konbu.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Felipe Balbi" <balbi@kernel.org>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Martin Schiller" <ms@dev.tdt.de>
Subject: Re: [RFT PATCH 2/4] usb: dwc2: Do not update data length if it is 0 on inbound transfers
Date: Thu, 27 Feb 2020 14:06:44 -0800 [thread overview]
Message-ID: <CAD=FV=UutvJE+k4W0sQDs6q+oOfbz5Tz670+L-8fFHfdB=KytQ@mail.gmail.com> (raw)
In-Reply-To: <20200226210414.28133-3-linux@roeck-us.net>
Hi,
On Wed, Feb 26, 2020 at 1:04 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The DWC2 documentation states that transfers with zero data length should
> set the number of packets to 1 and the transfer length to 0. This is not
> currently the case for inbound transfers: the transfer length is set to
> the maximum packet length. This can have adverse effects if the chip
> actually does transfer data as it is programmed to do. Follow chip
> documentation and keep the transfer length set to 0 in that situation.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/dwc2/hcd.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
I don't have any other test setup that you don't have, so just giving
my review tag and not tested tag.
I will note that it feels like this should have a "Fixes" tag or a
direct Cc to stable to make it obvious that it should make its way
back to stable trees.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2020-02-27 22:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:04 [RFT PATCH 0/4] usb: dwc2: Fixes and improvements Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 1/4] usb: dwc2: Simplify and fix DMA alignment code Guenter Roeck
2020-02-27 22:06 ` Doug Anderson
2020-02-27 22:27 ` Guenter Roeck
2020-02-28 4:28 ` Guenter Roeck
2020-02-28 16:14 ` Doug Anderson
2020-02-28 17:59 ` Guenter Roeck
2020-02-29 7:46 ` Antti Seppälä
2020-02-29 15:25 ` Guenter Roeck
2020-02-29 16:33 ` Antti Seppälä
2020-03-01 15:51 ` Antti Seppälä
2020-03-01 16:24 ` Guenter Roeck
2020-03-01 16:51 ` Antti Seppälä
2020-03-01 17:13 ` Guenter Roeck
2020-02-28 16:26 ` Stefan Wahren
2020-02-26 21:04 ` [RFT PATCH 2/4] usb: dwc2: Do not update data length if it is 0 on inbound transfers Guenter Roeck
2020-02-27 22:06 ` Doug Anderson [this message]
2020-02-28 0:32 ` Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 3/4] usb: dwc2: Abort transaction after errors with unknown reason Guenter Roeck
2020-02-27 22:06 ` Doug Anderson
2020-02-28 0:36 ` Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 4/4] usb: dwc2: Make "trimming xfer length" a debug message Guenter Roeck
2020-02-27 22:07 ` Doug Anderson
2020-02-28 0:38 ` Guenter Roeck
2020-02-29 1:50 ` [RFT PATCH 0/4] usb: dwc2: Fixes and improvements Boris ARZUR
2021-01-12 19:40 ` Nicolas Saenz Julienne
2021-01-12 19:44 ` Nicolas Saenz Julienne
2021-01-13 4:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UutvJE+k4W0sQDs6q+oOfbz5Tz670+L-8fFHfdB=KytQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=a.seppala@gmail.com \
--cc=balbi@kernel.org \
--cc=boris@konbu.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ms@dev.tdt.de \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).