From: "Antti Seppälä" <a.seppala@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Doug Anderson <dianders@chromium.org>,
Minas Harutyunyan <hminas@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Boris ARZUR <boris@konbu.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Martin Schiller <ms@dev.tdt.de>
Subject: Re: [RFT PATCH 1/4] usb: dwc2: Simplify and fix DMA alignment code
Date: Sat, 29 Feb 2020 18:33:36 +0200 [thread overview]
Message-ID: <CAKv9HNax9bK-60Gkv3ovZDAS_xVEQa95-J_9WKoEkifqa0u9+A@mail.gmail.com> (raw)
In-Reply-To: <62d81632-4a6f-b2d8-e420-b58fb6c9d044@roeck-us.net>
On Sat, 29 Feb 2020 at 17:25, Guenter Roeck <linux@roeck-us.net> wrote:
>
> Sigh. It would have been too simple. Too bad I can't test myself.
> I'd like to know if this is because URB_NO_TRANSFER_DMA_MAP is set on a
> transfer, or because the beginning of the buffer indeed needs to be aligned
> to the DMA cache line size on that system. In the latter case, the question
> is why the alignment to DWC2_USB_DMA_ALIGN (=4) works. In the former case,
> question would be why the realignment does any good in the first place.
>
> Any chance you can add some test code to help figuring out what exactly
> goes wrong ?
>
Sure, I can try to help. Just let me know what code you would like to
insert and where and I'll see what I can do.
--
Antti
next prev parent reply other threads:[~2020-02-29 16:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:04 [RFT PATCH 0/4] usb: dwc2: Fixes and improvements Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 1/4] usb: dwc2: Simplify and fix DMA alignment code Guenter Roeck
2020-02-27 22:06 ` Doug Anderson
2020-02-27 22:27 ` Guenter Roeck
2020-02-28 4:28 ` Guenter Roeck
2020-02-28 16:14 ` Doug Anderson
2020-02-28 17:59 ` Guenter Roeck
2020-02-29 7:46 ` Antti Seppälä
2020-02-29 15:25 ` Guenter Roeck
2020-02-29 16:33 ` Antti Seppälä [this message]
2020-03-01 15:51 ` Antti Seppälä
2020-03-01 16:24 ` Guenter Roeck
2020-03-01 16:51 ` Antti Seppälä
2020-03-01 17:13 ` Guenter Roeck
2020-02-28 16:26 ` Stefan Wahren
2020-02-26 21:04 ` [RFT PATCH 2/4] usb: dwc2: Do not update data length if it is 0 on inbound transfers Guenter Roeck
2020-02-27 22:06 ` Doug Anderson
2020-02-28 0:32 ` Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 3/4] usb: dwc2: Abort transaction after errors with unknown reason Guenter Roeck
2020-02-27 22:06 ` Doug Anderson
2020-02-28 0:36 ` Guenter Roeck
2020-02-26 21:04 ` [RFT PATCH 4/4] usb: dwc2: Make "trimming xfer length" a debug message Guenter Roeck
2020-02-27 22:07 ` Doug Anderson
2020-02-28 0:38 ` Guenter Roeck
2020-02-29 1:50 ` [RFT PATCH 0/4] usb: dwc2: Fixes and improvements Boris ARZUR
2021-01-12 19:40 ` Nicolas Saenz Julienne
2021-01-12 19:44 ` Nicolas Saenz Julienne
2021-01-13 4:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv9HNax9bK-60Gkv3ovZDAS_xVEQa95-J_9WKoEkifqa0u9+A@mail.gmail.com \
--to=a.seppala@gmail.com \
--cc=balbi@kernel.org \
--cc=boris@konbu.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ms@dev.tdt.de \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).