Linux-USB Archive on
 help / color / Atom feed
From: Martin Blumenstingl <>
To: Jens Axboe <>
Cc: Felipe Balbi <>,
	Greg Kroah-Hartman <>,
	USB list <>
Subject: Re: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
Date: Sat, 17 Oct 2020 17:46:06 +0200
Message-ID: <> (raw)
In-Reply-To: <>

Hi Jens,

On Sat, Oct 17, 2020 at 4:57 PM Jens Axboe <> wrote:
> Hi,
> There's a new warning in -git if:
> isn't set in the .config:
> drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
> drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
>   611 | error_debugfs:
>       | ^~~~~~~~~~~~~
> which was caused by this commit:
> commit e1c08cf23172ed6fb228d75efc9f4c80a6812116
> Author: Martin Blumenstingl <>
> Date:   Sat Jul 4 00:50:43 2020 +0200
>     usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
thanks for pointing this out! It seems like v2 of my patch was picked.
v3 [0] had this exact issue fixed which has been found by the kbuild
test robot
I can send a patch adding the #ifdefs so it can go into a for-linus
tree with a Fixes tag for the above commit
is there anything apart from that which needs to be done?

Best regards,


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 14:57 Jens Axboe
2020-10-17 15:46 ` Martin Blumenstingl [this message]
2020-10-17 16:02   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on

Archives are clonable:
	git clone --mirror linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ \
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone