linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
Date: Sat, 17 Oct 2020 17:46:06 +0200	[thread overview]
Message-ID: <CAFBinCAqwDPQ-dZVfV8kv777mqhSthbH7O7HMUpp6hy1KJLRhA@mail.gmail.com> (raw)
In-Reply-To: <c5e3148d-63c6-17f6-f4f8-1491ce8e6775@kernel.dk>

Hi Jens,

On Sat, Oct 17, 2020 at 4:57 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> Hi,
>
> There's a new warning in -git if:
>
> CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE
>
> isn't set in the .config:
>
> drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
> drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
>   611 | error_debugfs:
>       | ^~~~~~~~~~~~~
>
> which was caused by this commit:
>
> commit e1c08cf23172ed6fb228d75efc9f4c80a6812116
> Author: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Date:   Sat Jul 4 00:50:43 2020 +0200
>
>     usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
thanks for pointing this out! It seems like v2 of my patch was picked.
v3 [0] had this exact issue fixed which has been found by the kbuild
test robot
I can send a patch adding the #ifdefs so it can go into a for-linus
tree with a Fixes tag for the above commit
is there anything apart from that which needs to be done?


Best regards,
Martin


[0] https://lkml.org/lkml/2020/7/27/1429

  reply	other threads:[~2020-10-17 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 14:57 warning: label ‘error_debugfs’ defined but not used [-Wunused-label] Jens Axboe
2020-10-17 15:46 ` Martin Blumenstingl [this message]
2020-10-17 16:02   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFBinCAqwDPQ-dZVfV8kv777mqhSthbH7O7HMUpp6hy1KJLRhA@mail.gmail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=axboe@kernel.dk \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).