* warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
@ 2020-10-17 14:57 Jens Axboe
2020-10-17 15:46 ` Martin Blumenstingl
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2020-10-17 14:57 UTC (permalink / raw)
To: martin.blumenstingl, Felipe Balbi, Greg Kroah-Hartman, USB list
Hi,
There's a new warning in -git if:
CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE
isn't set in the .config:
drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
611 | error_debugfs:
| ^~~~~~~~~~~~~
which was caused by this commit:
commit e1c08cf23172ed6fb228d75efc9f4c80a6812116
Author: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Sat Jul 4 00:50:43 2020 +0200
usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
2020-10-17 14:57 warning: label ‘error_debugfs’ defined but not used [-Wunused-label] Jens Axboe
@ 2020-10-17 15:46 ` Martin Blumenstingl
2020-10-17 16:02 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2020-10-17 15:46 UTC (permalink / raw)
To: Jens Axboe; +Cc: Felipe Balbi, Greg Kroah-Hartman, USB list
Hi Jens,
On Sat, Oct 17, 2020 at 4:57 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> Hi,
>
> There's a new warning in -git if:
>
> CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE
>
> isn't set in the .config:
>
> drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
> drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
> 611 | error_debugfs:
> | ^~~~~~~~~~~~~
>
> which was caused by this commit:
>
> commit e1c08cf23172ed6fb228d75efc9f4c80a6812116
> Author: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Date: Sat Jul 4 00:50:43 2020 +0200
>
> usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
thanks for pointing this out! It seems like v2 of my patch was picked.
v3 [0] had this exact issue fixed which has been found by the kbuild
test robot
I can send a patch adding the #ifdefs so it can go into a for-linus
tree with a Fixes tag for the above commit
is there anything apart from that which needs to be done?
Best regards,
Martin
[0] https://lkml.org/lkml/2020/7/27/1429
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
2020-10-17 15:46 ` Martin Blumenstingl
@ 2020-10-17 16:02 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-10-17 16:02 UTC (permalink / raw)
To: Martin Blumenstingl; +Cc: Felipe Balbi, Greg Kroah-Hartman, USB list
On 10/17/20 9:46 AM, Martin Blumenstingl wrote:
> Hi Jens,
>
> On Sat, Oct 17, 2020 at 4:57 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Hi,
>>
>> There's a new warning in -git if:
>>
>> CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE
>>
>> isn't set in the .config:
>>
>> drivers/usb/dwc2/platform.c: In function ‘dwc2_driver_probe’:
>> drivers/usb/dwc2/platform.c:611:1: warning: label ‘error_debugfs’ defined but not used [-Wunused-label]
>> 611 | error_debugfs:
>> | ^~~~~~~~~~~~~
>>
>> which was caused by this commit:
>>
>> commit e1c08cf23172ed6fb228d75efc9f4c80a6812116
>> Author: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Date: Sat Jul 4 00:50:43 2020 +0200
>>
>> usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
> thanks for pointing this out! It seems like v2 of my patch was picked.
> v3 [0] had this exact issue fixed which has been found by the kbuild
> test robot
> I can send a patch adding the #ifdefs so it can go into a for-linus
> tree with a Fixes tag for the above commit
> is there anything apart from that which needs to be done?
That seems about right, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-17 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-17 14:57 warning: label ‘error_debugfs’ defined but not used [-Wunused-label] Jens Axboe
2020-10-17 15:46 ` Martin Blumenstingl
2020-10-17 16:02 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).