linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas
@ 2019-11-18 10:07 Pacho Ramos
  2019-11-18 11:28 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Pacho Ramos @ 2019-11-18 10:07 UTC (permalink / raw)
  To: linux-usb

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hello,

I would like to forward the patch that is being used for years in
Fedora and Gentoo to fix connectivity issues of JMicron devices with
UAS when they got into idle state:
https://bugzilla.redhat.com/show_bug.cgi?id=1260207
https://bugs.gentoo.org/640082

The problem is still valid with current kernels, then, I guess the
patch wasn't forwarded here or got forgotten for some reason. This
patch works fine for current kernel 4.13.11 too

Thanks a lot

[-- Attachment #2: 2500_usb-storage-Disable-UAS-on-JMicron-SATA-enclosure.patch --]
[-- Type: text/x-patch, Size: 1372 bytes --]

From d02a55182307c01136b599fd048b4679f259a84e Mon Sep 17 00:00:00 2001
From: Laura Abbott <labbott@fedoraproject.org>
Date: Tue, 8 Sep 2015 09:53:38 -0700
Subject: [PATCH] usb-storage: Disable UAS on JMicron SATA enclosure

Steve Ellis reported incorrect block sizes and alignement
offsets with a SATA enclosure. Adding a quirk to disable
UAS fixes the problems.

Reported-by: Steven Ellis <sellis@redhat.com>
Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
---
 drivers/usb/storage/unusual_uas.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index c85ea53..216d93d 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -141,12 +141,15 @@ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_ATA_1X),
 
-/* Reported-by: Takeo Nakayama <javhera@gmx.com> */
+/*
+ * Initially Reported-by: Takeo Nakayama <javhera@gmx.com>
+ * UAS Ignore Reported by Steven Ellis <sellis@redhat.com>
+ */
 UNUSUAL_DEV(0x357d, 0x7788, 0x0000, 0x9999,
 		"JMicron",
 		"JMS566",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-		US_FL_NO_REPORT_OPCODES),
+		US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS),
 
 /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
 UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999,
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas
  2019-11-18 10:07 JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas Pacho Ramos
@ 2019-11-18 11:28 ` Greg KH
  2019-11-18 15:44   ` Laura Abbott
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-11-18 11:28 UTC (permalink / raw)
  To: Pacho Ramos, Laura Abbott; +Cc: linux-usb

On Mon, Nov 18, 2019 at 11:07:55AM +0100, Pacho Ramos wrote:
> Hello,
> 
> I would like to forward the patch that is being used for years in
> Fedora and Gentoo to fix connectivity issues of JMicron devices with
> UAS when they got into idle state:
> https://bugzilla.redhat.com/show_bug.cgi?id=1260207
> https://bugs.gentoo.org/640082
> 
> The problem is still valid with current kernels, then, I guess the
> patch wasn't forwarded here or got forgotten for some reason. This
> patch works fine for current kernel 4.13.11 too

Laura, any reason this patch was never sent upstream to us?  Any
objection for the patch below to be merged?

thanks,

greg k-h

> From d02a55182307c01136b599fd048b4679f259a84e Mon Sep 17 00:00:00 2001
> From: Laura Abbott <labbott@fedoraproject.org>
> Date: Tue, 8 Sep 2015 09:53:38 -0700
> Subject: [PATCH] usb-storage: Disable UAS on JMicron SATA enclosure
> 
> Steve Ellis reported incorrect block sizes and alignement
> offsets with a SATA enclosure. Adding a quirk to disable
> UAS fixes the problems.
> 
> Reported-by: Steven Ellis <sellis@redhat.com>
> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index c85ea53..216d93d 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -141,12 +141,15 @@ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_NO_ATA_1X),
>  
> -/* Reported-by: Takeo Nakayama <javhera@gmx.com> */
> +/*
> + * Initially Reported-by: Takeo Nakayama <javhera@gmx.com>
> + * UAS Ignore Reported by Steven Ellis <sellis@redhat.com>
> + */
>  UNUSUAL_DEV(0x357d, 0x7788, 0x0000, 0x9999,
>  		"JMicron",
>  		"JMS566",
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> -		US_FL_NO_REPORT_OPCODES),
> +		US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS),
>  
>  /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
>  UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999,
> -- 
> 2.4.3
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas
  2019-11-18 11:28 ` Greg KH
@ 2019-11-18 15:44   ` Laura Abbott
  2019-11-18 15:58     ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Laura Abbott @ 2019-11-18 15:44 UTC (permalink / raw)
  To: Greg KH, Pacho Ramos, Laura Abbott; +Cc: linux-usb

On 11/18/19 6:28 AM, Greg KH wrote:
> On Mon, Nov 18, 2019 at 11:07:55AM +0100, Pacho Ramos wrote:
>> Hello,
>>
>> I would like to forward the patch that is being used for years in
>> Fedora and Gentoo to fix connectivity issues of JMicron devices with
>> UAS when they got into idle state:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1260207
>> https://bugs.gentoo.org/640082
>>
>> The problem is still valid with current kernels, then, I guess the
>> patch wasn't forwarded here or got forgotten for some reason. This
>> patch works fine for current kernel 4.13.11 too
> 
> Laura, any reason this patch was never sent upstream to us?  Any
> objection for the patch below to be merged?
> 

Huh this must have completely slipped off my radar. No objections.
Thanks for the follow up!

> thanks,
> 
> greg k-h
> 
>>  From d02a55182307c01136b599fd048b4679f259a84e Mon Sep 17 00:00:00 2001
>> From: Laura Abbott <labbott@fedoraproject.org>
>> Date: Tue, 8 Sep 2015 09:53:38 -0700
>> Subject: [PATCH] usb-storage: Disable UAS on JMicron SATA enclosure
>>
>> Steve Ellis reported incorrect block sizes and alignement
>> offsets with a SATA enclosure. Adding a quirk to disable
>> UAS fixes the problems.
>>
>> Reported-by: Steven Ellis <sellis@redhat.com>
>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>> ---
>>   drivers/usb/storage/unusual_uas.h | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
>> index c85ea53..216d93d 100644
>> --- a/drivers/usb/storage/unusual_uas.h
>> +++ b/drivers/usb/storage/unusual_uas.h
>> @@ -141,12 +141,15 @@ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
>>   		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>   		US_FL_NO_ATA_1X),
>>   
>> -/* Reported-by: Takeo Nakayama <javhera@gmx.com> */
>> +/*
>> + * Initially Reported-by: Takeo Nakayama <javhera@gmx.com>
>> + * UAS Ignore Reported by Steven Ellis <sellis@redhat.com>
>> + */
>>   UNUSUAL_DEV(0x357d, 0x7788, 0x0000, 0x9999,
>>   		"JMicron",
>>   		"JMS566",
>>   		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>> -		US_FL_NO_REPORT_OPCODES),
>> +		US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS),
>>   
>>   /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
>>   UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999,
>> -- 
>> 2.4.3
>>
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas
  2019-11-18 15:44   ` Laura Abbott
@ 2019-11-18 15:58     ` Greg KH
  2019-11-18 16:03       ` Pacho Ramos
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-11-18 15:58 UTC (permalink / raw)
  To: Laura Abbott; +Cc: Pacho Ramos, Laura Abbott, linux-usb

On Mon, Nov 18, 2019 at 10:44:03AM -0500, Laura Abbott wrote:
> On 11/18/19 6:28 AM, Greg KH wrote:
> > On Mon, Nov 18, 2019 at 11:07:55AM +0100, Pacho Ramos wrote:
> > > Hello,
> > > 
> > > I would like to forward the patch that is being used for years in
> > > Fedora and Gentoo to fix connectivity issues of JMicron devices with
> > > UAS when they got into idle state:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1260207
> > > https://bugs.gentoo.org/640082
> > > 
> > > The problem is still valid with current kernels, then, I guess the
> > > patch wasn't forwarded here or got forgotten for some reason. This
> > > patch works fine for current kernel 4.13.11 too
> > 
> > Laura, any reason this patch was never sent upstream to us?  Any
> > objection for the patch below to be merged?
> > 
> 
> Huh this must have completely slipped off my radar. No objections.
> Thanks for the follow up!

Ok, now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas
  2019-11-18 15:58     ` Greg KH
@ 2019-11-18 16:03       ` Pacho Ramos
  0 siblings, 0 replies; 5+ messages in thread
From: Pacho Ramos @ 2019-11-18 16:03 UTC (permalink / raw)
  To: Greg KH; +Cc: Laura Abbott, Laura Abbott, linux-usb

Thanks a lot!

El lun., 18 nov. 2019 a las 17:00, Greg KH
(<gregkh@linuxfoundation.org>) escribió:
>
> On Mon, Nov 18, 2019 at 10:44:03AM -0500, Laura Abbott wrote:
> > On 11/18/19 6:28 AM, Greg KH wrote:
> > > On Mon, Nov 18, 2019 at 11:07:55AM +0100, Pacho Ramos wrote:
> > > > Hello,
> > > >
> > > > I would like to forward the patch that is being used for years in
> > > > Fedora and Gentoo to fix connectivity issues of JMicron devices with
> > > > UAS when they got into idle state:
> > > > https://bugzilla.redhat.com/show_bug.cgi?id=1260207
> > > > https://bugs.gentoo.org/640082
> > > >
> > > > The problem is still valid with current kernels, then, I guess the
> > > > patch wasn't forwarded here or got forgotten for some reason. This
> > > > patch works fine for current kernel 4.13.11 too
> > >
> > > Laura, any reason this patch was never sent upstream to us?  Any
> > > objection for the patch below to be merged?
> > >
> >
> > Huh this must have completely slipped off my radar. No objections.
> > Thanks for the follow up!
>
> Ok, now queued up, thanks.
>
> greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-18 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 10:07 JMicron USB to ATA/ATAPI Bridge requires usb-storage quirks to disable uas Pacho Ramos
2019-11-18 11:28 ` Greg KH
2019-11-18 15:44   ` Laura Abbott
2019-11-18 15:58     ` Greg KH
2019-11-18 16:03       ` Pacho Ramos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).