* [PATCH v3 -next] usb: cdns3: Fix sheduling with locks held.
@ 2019-09-26 7:58 Pawel Laszczak
2019-09-27 8:29 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Laszczak @ 2019-09-26 7:58 UTC (permalink / raw)
To: gregkh, linux-usb, felipe.balbi; +Cc: dan.carpenter, Pawel Laszczak
Patch fix issue in cdns3_ep0_feature_handle_device function.
The function usleep_range can't be used there because this function is
called with locks held and IRQs disabled in
cdns3_device_thread_irq_handler().
To resolve this issue patch replaces usleep_range with mdelay.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
---
v2: added Reported-by and Fixes tags
v3: added version of the patch
---
drivers/usb/cdns3/ep0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c
index 44f652e8b5a2..0445da0a5a0c 100644
--- a/drivers/usb/cdns3/ep0.c
+++ b/drivers/usb/cdns3/ep0.c
@@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
* for sending status stage.
* This time should be less then 3ms.
*/
- usleep_range(1000, 2000);
+ mdelay(1);
cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
USB_CMD_STMODE |
USB_STS_TMODE_SEL(tmode - 1));
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 -next] usb: cdns3: Fix sheduling with locks held.
2019-09-26 7:58 [PATCH v3 -next] usb: cdns3: Fix sheduling with locks held Pawel Laszczak
@ 2019-09-27 8:29 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2019-09-27 8:29 UTC (permalink / raw)
To: Pawel Laszczak; +Cc: Greg Kroah-Hartman, USB list, felipe.balbi, dan.carpenter
On Thu, Sep 26, 2019 at 6:26 PM Pawel Laszczak <pawell@cadence.com> wrote:
>
> Patch fix issue in cdns3_ep0_feature_handle_device function.
>
> The function usleep_range can't be used there because this function is
> called with locks held and IRQs disabled in
> cdns3_device_thread_irq_handler().
>
> To resolve this issue patch replaces usleep_range with mdelay.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> ---
> v2: added Reported-by and Fixes tags
> v3: added version of the patch
> ---
> drivers/usb/cdns3/ep0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c
> index 44f652e8b5a2..0445da0a5a0c 100644
> --- a/drivers/usb/cdns3/ep0.c
> +++ b/drivers/usb/cdns3/ep0.c
> @@ -332,7 +332,7 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
> * for sending status stage.
> * This time should be less then 3ms.
> */
> - usleep_range(1000, 2000);
> + mdelay(1);
> cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
> USB_CMD_STMODE |
> USB_STS_TMODE_SEL(tmode - 1));
> --
> 2.17.1
>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-27 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 7:58 [PATCH v3 -next] usb: cdns3: Fix sheduling with locks held Pawel Laszczak
2019-09-27 8:29 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).