From: Alan Stern <stern@rowland.harvard.edu>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 3/5] USB: Implement usb_device_match_id()
Date: Wed, 9 Oct 2019 13:29:49 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1910091328120.1603-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <2bbaeba7abb332aaf9fb521602f7199ba1e77273.camel@hadess.net>
On Wed, 9 Oct 2019, Bastien Nocera wrote:
> > This would be better if you allowed matching against just the
> > idVendor
> > field rather than matching against both. That would make it a lot
> > simpler to match all Apple devices, for instance.
>
> That should already be possible. The matching code is the same as for
> the USB interface drivers.
>
> Something like:
> static const struct usb_device_id apple_match[] = {
> { .match_flags = USB_DEVICE_ID_MATCH_VENDOR,
> .idVendor = USB_VENDOR_APPLE
> },
> {}
> }
>
> And I couldn't use it in patch 5/5, as that's a range of product IDs,
> not all of them (which would be quite a lot more).
You can still use it in patch 5/5. Match any device with Apple's VID;
then have the probe routine return -ENODEV if the PID is outside the
range you want.
Alan Stern
next prev parent reply other threads:[~2019-10-09 17:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:43 [PATCH 0/5] Add Apple MFi fastcharge USB device driver Bastien Nocera
2019-10-09 13:43 ` [PATCH 1/5] USB: Export generic USB device driver functions Bastien Nocera
2019-10-09 13:43 ` [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver Bastien Nocera
2019-10-09 14:34 ` Alan Stern
2019-10-09 14:41 ` Alan Stern
2019-10-10 8:10 ` Bastien Nocera
2019-10-10 9:58 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 3/5] USB: Implement usb_device_match_id() Bastien Nocera
2019-10-09 14:36 ` Alan Stern
2019-10-09 15:40 ` Bastien Nocera
2019-10-09 17:29 ` Alan Stern [this message]
2019-10-09 13:43 ` [PATCH 4/5] USB: Select better matching USB drivers when available Bastien Nocera
2019-10-09 14:43 ` Alan Stern
2019-10-09 15:35 ` Bastien Nocera
2019-10-09 17:28 ` Alan Stern
2019-10-09 18:24 ` Bastien Nocera
2019-10-09 18:45 ` Alan Stern
2019-10-10 8:26 ` Bastien Nocera
2019-10-10 14:19 ` Alan Stern
2019-10-10 10:33 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 5/5] USB: Add driver to control USB fast charge for iOS devices Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1910091328120.1603-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).