* [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
@ 2022-05-05 10:14 monish.kumar.r
2022-05-05 10:21 ` Oliver Neukum
2022-05-05 12:17 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: monish.kumar.r @ 2022-05-05 10:14 UTC (permalink / raw)
To: gregkh, olebowle, oneukum, vpalatin, wangjm221, chris.chiu,
linux-usb, linux-kernel
Cc: monish.kumar.r, abhijeet.rao
From: Monish Kumar R <monish.kumar.r@intel.com>
Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
---
drivers/usb/core/quirks.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 97b44a68668a..257ac37464e8 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
/* INTEL VALUE SSD */
{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
+ /*DELL USB GEN2 */
+ { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
+ { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
{ } /* terminating entry must be last */
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
2022-05-05 10:14 [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration monish.kumar.r
@ 2022-05-05 10:21 ` Oliver Neukum
2022-05-05 12:17 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2022-05-05 10:21 UTC (permalink / raw)
To: monish.kumar.r, gregkh, olebowle, oneukum, vpalatin, wangjm221,
chris.chiu, linux-usb, linux-kernel
Cc: abhijeet.rao
On 05.05.22 12:14, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>
> + /*DELL USB GEN2 */
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
>
>
Hi,
could you please
1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or
"reported on list"
Regards
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
2022-05-05 10:14 [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration monish.kumar.r
2022-05-05 10:21 ` Oliver Neukum
@ 2022-05-05 12:17 ` Greg KH
2022-05-06 5:28 ` R, Monish Kumar
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-05-05 12:17 UTC (permalink / raw)
To: monish.kumar.r
Cc: olebowle, oneukum, vpalatin, wangjm221, chris.chiu, linux-usb,
linux-kernel, abhijeet.rao
On Thu, May 05, 2022 at 03:44:59PM +0530, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>
> + /*DELL USB GEN2 */
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
Are you sure you need both? How was this tested that both are actually
set?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
2022-05-05 12:17 ` Greg KH
@ 2022-05-06 5:28 ` R, Monish Kumar
0 siblings, 0 replies; 6+ messages in thread
From: R, Monish Kumar @ 2022-05-06 5:28 UTC (permalink / raw)
To: Greg KH
Cc: olebowle, oneukum, vpalatin, wangjm221, chris.chiu, linux-usb,
linux-kernel, Rao, Abhijeet
Hi greg,
Are you sure you need both? How was this tested that both are actually set?
>> Yes, both NO_LPM and RESET_RESUME quirks were needed.
As the Dell usb gen2 device U1/U2 link states were failing when connected to type-C ports.
Disabling LPM helps to resolve U1/U2 link state failures. However, it leads to resetting the device multiple times. So, added with NO_LPM and RESET_RESUME usb quirks.
Tested multiple hotplug of Dell usb gen 2 device, it passed for all the cases.
Regards,
Monish Kumar R
-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>
Sent: 05 May 2022 17:47
To: R, Monish Kumar <monish.kumar.r@intel.com>
Cc: olebowle@gmx.com; oneukum@suse.com; vpalatin@chromium.org; wangjm221@gmail.com; chris.chiu@canonical.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Rao, Abhijeet <abhijeet.rao@intel.com>
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
On Thu, May 05, 2022 at 03:44:59PM +0530, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id
> usb_quirk_list[] = {
>
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME
> },
>
> + /*DELL USB GEN2 */
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME
> +},
Are you sure you need both? How was this tested that both are actually set?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
2022-05-20 13:00 monish.kumar.r
@ 2022-05-20 19:19 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2022-05-20 19:19 UTC (permalink / raw)
To: monish.kumar.r
Cc: oneukum, olebowle, davem, wangjm221, chris.chiu, vpalatin,
linux-usb, linux-kernel, abhijeet.rao
On Fri, May 20, 2022 at 06:30:44PM +0530, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>
> Found this bug on own testing
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
I have fixed this up by hand, but next time please run this through the
Intel open source review process first before sending it out so that I
will not have to fix up further patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.
@ 2022-05-20 13:00 monish.kumar.r
2022-05-20 19:19 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: monish.kumar.r @ 2022-05-20 13:00 UTC (permalink / raw)
To: gregkh, oneukum, olebowle, davem, wangjm221, chris.chiu,
vpalatin, linux-usb, linux-kernel
Cc: monish.kumar.r, abhijeet.rao
From: Monish Kumar R <monish.kumar.r@intel.com>
Found this bug on own testing
Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
---
drivers/usb/core/quirks.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 97b44a68668a..f9e149fc4395 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -510,6 +510,10 @@ static const struct usb_device_id usb_quirk_list[] = {
/* DJI CineSSD */
{ USB_DEVICE(0x2ca3, 0x0031), .driver_info = USB_QUIRK_NO_LPM },
+ /*DELL USB GEN2 */
+ { USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM |
+ USB_QUIRK_RESET_RESUME },
+
/* VCOM device */
{ USB_DEVICE(0x4296, 0x7570), .driver_info = USB_QUIRK_CONFIG_INTF_STRINGS },
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-20 19:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 10:14 [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration monish.kumar.r
2022-05-05 10:21 ` Oliver Neukum
2022-05-05 12:17 ` Greg KH
2022-05-06 5:28 ` R, Monish Kumar
2022-05-20 13:00 monish.kumar.r
2022-05-20 19:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).