From: Peter Chen <peter.chen@nxp.com>
To: Allen Blaylock <AllenB@epiloglaser.com>,
Manu Gautam <mgautam@codeaurora.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: EHSET with hub and PCIe root hub
Date: Thu, 12 Sep 2019 00:49:50 +0000 [thread overview]
Message-ID: <VI1PR04MB5327073659D605C6641E935F8BB00@VI1PR04MB5327.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BYAPR20MB2501098ADC3493845D7D2E9DCCB10@BYAPR20MB2501.namprd20.prod.outlook.com>
> >>>
> >>> Further down in the mailing list chain Peter Chen states
> >>>> Besides, do not connect HUB between your host board and emulation
> >>>> board (for sending VID/PID).
> >>> but there is no additional information regarding this statement.
> >> EHSET is used to test embedded host electrical signal required by USB
> >> IF Compliance Test, not test the signal for USB HUB, since the EHSET
> >> module could only let embedded host controller enter test mode by
> >> writing TEST MODE registers follows EHCI or xHCI spec. Maybe the USB
> >> HUB could let its port enter test mode, but it needs to use other
> >> ways, maybe vendor specific commands.
> >
> >IMO ehset should work with external HUB as well since all it takes to put a HUB's
> port in compliance mode is sending a SetFeature request which I believe driver
> already does. If HUB is sending stall then you can try putting a different port in
> compliance which is not connected.
>
> How do I specify which port I put in compliance? The way I have been doing it was
> using a PIDVID from testusb.com which, as I understand it, turns into the correct
> device by setting its VID and PID so by nature of how it works I must have a
> "device" connected.
>
Which port your test device is connected, then which port will enter test mode, it is
controlled by EHSET. The test device's VID/PID must be the same with ehset_id_table
in ehset.c.
For external HUB, I have never done since I only test USB controller on SoC.
As Manu said, if it supports the commands in EHSET in its firmware, it should support
put its downstream port in test mode.
Peter
next prev parent reply other threads:[~2019-09-12 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 22:01 EHSET with hub and PCIe root hub Allen Blaylock
2019-09-11 2:57 ` Peter Chen
2019-09-11 3:54 ` Manu Gautam
2019-09-11 20:34 ` Allen Blaylock
2019-09-12 0:49 ` Peter Chen [this message]
2019-09-12 14:20 ` Alan Stern
2019-09-12 14:28 ` Alan Stern
2019-09-12 20:32 ` Allen Blaylock
2019-09-12 20:51 ` Alan Stern
2019-09-16 1:11 ` Peter Chen
2019-09-12 14:29 ` Allen Blaylock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5327073659D605C6641E935F8BB00@VI1PR04MB5327.eurprd04.prod.outlook.com \
--to=peter.chen@nxp.com \
--cc=AllenB@epiloglaser.com \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).