* [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:" - Adjust to approoriate line
@ 2020-11-18 6:51 penghao
2020-11-18 6:59 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: penghao @ 2020-11-18 6:51 UTC (permalink / raw)
To: gregkh
Cc: johan, jonathan, tomasz, penghao, hdegoede, dlaz, kai.heng.feng,
richard.o.dodd, kerneldev, linux-usb, linux-kernel
USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for
Lenovo A630Z TIO built-in usb-audio card
Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in
usb-audio. when A630Z going into S3,the system immediately wakeup 7-8
seconds later by usb-audio disconnect interrupt to avoids the issue.
Seeking a better fix, we've tried a lot of things, including:
- Check that the device's power/wakeup is disabled
- Check that remote wakeup is off at the USB level
- All the quirks in drivers/usb/core/quirks.c
e.g. USB_QUIRK_RESET_RESUME,
USB_QUIRK_RESET,
USB_QUIRK_IGNORE_REMOTE_WAKEUP,
USB_QUIRK_NO_LPM.
but none of that makes any difference.
There are no errors in the logs showing any suspend/resume-related issues.
When the system wakes up due to the modem, log-wise it appears to be a
normal resume.
Introduce a quirk to disable the port during suspend when the modem is
detected.
Signed-off-by: penghao <penghao@uniontech.com>
---
drivers/usb/core/quirks.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7c1198f80c23..8d18e89f9eb0 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -410,7 +410,11 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x1532, 0x0116), .driver_info =
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
- /* BUILDWIN Photo Frame */
+/* Lenovo - ThinkCenter A630Z TI024Gen3 usb-audio card */
+{ USB_DEVICE(0x17ef, 0x0xa012), .driver_info =
+USB_QUIRK_DISCONNECT_SUSPEND },
+
+ /* BUILDWIN Photo Frame */
{ USB_DEVICE(0x1908, 0x1315), .driver_info =
USB_QUIRK_HONOR_BNUMINTERFACES },
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:" - Adjust to approoriate line
2020-11-18 6:51 [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:" - Adjust to approoriate line penghao
@ 2020-11-18 6:59 ` Greg KH
[not found] ` <97724690.63131.1605685268737.JavaMail.xmail@bj-wm-cp-6>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-11-18 6:59 UTC (permalink / raw)
To: penghao
Cc: johan, jonathan, tomasz, hdegoede, dlaz, kai.heng.feng,
richard.o.dodd, kerneldev, linux-usb, linux-kernel
On Wed, Nov 18, 2020 at 02:51:32PM +0800, penghao wrote:
> USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for
> Lenovo A630Z TIO built-in usb-audio card
Your subject line does not work, please put that information below the
--- line.
Also, we need a "real" name for the From: and signed-off-by line please.
> Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in
> usb-audio. when A630Z going into S3,the system immediately wakeup 7-8
> seconds later by usb-audio disconnect interrupt to avoids the issue.
>
> Seeking a better fix, we've tried a lot of things, including:
> - Check that the device's power/wakeup is disabled
> - Check that remote wakeup is off at the USB level
> - All the quirks in drivers/usb/core/quirks.c
> e.g. USB_QUIRK_RESET_RESUME,
> USB_QUIRK_RESET,
> USB_QUIRK_IGNORE_REMOTE_WAKEUP,
> USB_QUIRK_NO_LPM.
>
> but none of that makes any difference.
>
> There are no errors in the logs showing any suspend/resume-related issues.
> When the system wakes up due to the modem, log-wise it appears to be a
> normal resume.
>
> Introduce a quirk to disable the port during suspend when the modem is
> detected.
>
> Signed-off-by: penghao <penghao@uniontech.com>
> ---
> drivers/usb/core/quirks.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..8d18e89f9eb0 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -410,7 +410,11 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x1532, 0x0116), .driver_info =
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> - /* BUILDWIN Photo Frame */
> +/* Lenovo - ThinkCenter A630Z TI024Gen3 usb-audio card */
> +{ USB_DEVICE(0x17ef, 0x0xa012), .driver_info =
> +USB_QUIRK_DISCONNECT_SUSPEND },
> +
> + /* BUILDWIN Photo Frame */
Your patch seems to have messed up spaces and tabs here, please fix that
up in your editor and always run scripts/checkpatch.pl on your patch
before resending it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:"- Adjust to approoriate line
[not found] ` <97724690.63131.1605685268737.JavaMail.xmail@bj-wm-cp-6>
@ 2020-11-18 7:46 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-11-18 7:46 UTC (permalink / raw)
To: 彭浩
Cc: johan, jonathan, tomasz, hdegoede, dlaz, kai.heng.feng ,
richard.o.dodd ,
kerneldev, linux-usb, linux-kernel
On Wed, Nov 18, 2020 at 03:41:08PM +0800, 彭浩 wrote:
> 此电子邮件消息仅供预期收件人使用,其中可能包含保密或特权使用信息。如果您不是预
> 期收件人,请勿使用、传播、分发或复制此电子邮件或信赖此邮件采取任何行动。如果您
> 误收了此邮件,请立即回复邮件通知统信软件技术有限公司发件人,并删除误收电子邮件
> 及其相关附件。感谢配合!
>
> This email message is intended only for the use of the individual or entity who
> /which is the intended recipient and may contain information that is privileged
> or confidential. If you are not the intended recipient, you are hereby notified
> that any use, dissemination, distribution or copying of, or taking any action
> in reliance on, this e-mail is strictly prohibited. If you have received this
> email in error, please notify UnionTech Software Technology immediately by
> replying to this e-mail and immediately delete and discard all copies of the
> e-mail and the attachment thereto (if any). Thank you.
Message is now deleted.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-18 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 6:51 [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:" - Adjust to approoriate line penghao
2020-11-18 6:59 ` Greg KH
[not found] ` <97724690.63131.1605685268737.JavaMail.xmail@bj-wm-cp-6>
2020-11-18 7:46 ` Re: [PATCH] Changes since v1 - Change subject form "ALSA" to "USB:"- " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).