From: Johan Hovold <johan@kernel.org>
To: "Michael G. Katzmann" <michaelk@IEEE.org>
Cc: charles-yeh@prolific.com.tw, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, Charles Yeh <charlesyeh522@gmail.com>,
Joe Abbott <jabbott@rollanet.org>
Subject: Re: non-standard baud rates with Prolific 2303 USB-serial
Date: Thu, 25 Feb 2021 09:42:20 +0100 [thread overview]
Message-ID: <YDdi7NcnzgQDMzZH@hovoldconsulting.com> (raw)
In-Reply-To: <2162ce18-32e9-e54c-f266-47febdea11f1@IEEE.org>
On Wed, Feb 24, 2021 at 01:13:39PM -0500, Michael G. Katzmann wrote:
> On 2/24/21 12:04 PM, Johan Hovold wrote:
> > Perhaps you can even figure out how to poll for an empty TX FIFO from
> > it, unless Charles is able to provide some details on that separate
> > matter?
>
> I presume from the code below, that when the device is closed, all
> data waiting to send is clobbered (if so, so the problem is the driver
> and not the device)
>
> I would have thought that the driver should drain the buffers. I can
> see that this might be a problem if there is flow control (it may
> never drain) but the current method seems pretty brutal.
We do; the code below isn't called until after we've waited for the
buffers to drain (driver buffers + device FIFO).
I'll provide a patch so that you can extend the timeout for draining the
driver buffers (defaults to 30 s), but the main problem is that we don't
know how to query the PL2303 FIFO fill level.
> 119 void usb_serial_generic_close(struct usb_serial_port *port)
> 120 {
> 121 unsigned long flags;
> 122 int i;
> 123
> 124 if (port->bulk_out_size) {
> 125 for (i = 0; i < ARRAY_SIZE(port->write_urbs); ++i)
> 126 usb_kill_urb(port->write_urbs[i]);
> 127
> 128 spin_lock_irqsave(&port->lock, flags);
> 129 kfifo_reset_out(&port->write_fifo);
> 130 spin_unlock_irqrestore(&port->lock, flags);
> 131 }
> 132 if (port->bulk_in_size) {
> 133 for (i = 0; i < ARRAY_SIZE(port->read_urbs); ++i)
> 134 usb_kill_urb(port->read_urbs[i]);
> 135 }
> 136 }
Johan
next prev parent reply other threads:[~2021-02-25 8:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3aee5708-7961-f464-8c5f-6685d96920d6@IEEE.org>
[not found] ` <dc3458f1-830b-284b-3464-20124dc3900a@IEEE.org>
2021-02-22 8:52 ` non-standard baud rates with Prolific 2303 USB-serial Johan Hovold
2021-02-22 12:39 ` Michael G. Katzmann
2021-02-22 13:18 ` Johan Hovold
[not found] ` <fb1489c2-b972-619b-b7ce-4ae8e1d2cc0f@IEEE.org>
2021-02-22 15:34 ` Johan Hovold
2021-02-22 15:42 ` Michael G. Katzmann
2021-02-22 15:50 ` Johan Hovold
2021-02-22 16:37 ` Michael G. Katzmann
2021-02-22 16:48 ` Johan Hovold
2021-02-24 23:08 ` Joe Abbott
2021-02-25 8:44 ` Johan Hovold
[not found] ` <43da22ced8e14442bbc8babea77e4ed7@MailHC2.prolific.com.tw>
2021-02-23 10:18 ` Johan Hovold
2021-02-23 13:25 ` Michael G. Katzmann
2021-02-23 14:58 ` Michael G. Katzmann
2021-02-23 15:43 ` Johan Hovold
2021-02-23 15:57 ` Michael G. Katzmann
2021-02-23 16:14 ` Johan Hovold
2021-02-23 16:30 ` Michael G. Katzmann
2021-02-23 16:52 ` Johan Hovold
2021-02-23 19:15 ` Michael G. Katzmann
2021-02-24 17:04 ` Johan Hovold
2021-02-24 18:13 ` Michael G. Katzmann
2021-02-25 8:42 ` Johan Hovold [this message]
2021-04-08 15:35 ` Johan Hovold
2021-02-24 7:34 ` Charles Yeh
2021-02-24 17:00 ` Johan Hovold
2021-02-24 17:12 ` Michael G. Katzmann
2021-03-05 9:32 ` Charles Yeh
2021-03-05 9:36 ` Johan Hovold
2021-03-06 20:18 ` Michael G. Katzmann
2021-03-07 4:15 ` Michael G. Katzmann
2021-03-11 16:08 ` Johan Hovold
2021-03-12 13:17 ` Michael G. Katzmann
2021-03-12 13:44 ` Johan Hovold
2021-03-12 20:29 ` Michael G. Katzmann
2021-03-13 1:28 ` Michael G. Katzmann
2021-03-15 9:07 ` Johan Hovold
2021-03-15 10:07 ` Charles Yeh
2021-03-15 10:24 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDdi7NcnzgQDMzZH@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=charles-yeh@prolific.com.tw \
--cc=charlesyeh522@gmail.com \
--cc=jabbott@rollanet.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michaelk@IEEE.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).