linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/1] USB: serial: ch341: add new Product ID
@ 2021-03-01 20:16 Niv Sardi
  2021-03-01 20:16 ` [PATCH v3] " Niv Sardi
  0 siblings, 1 reply; 3+ messages in thread
From: Niv Sardi @ 2021-03-01 20:16 UTC (permalink / raw)
  To: linux-usb; +Cc: Niv Sardi

v3 based on feedback from Johan Hovold:
 - remove link to ANU232MI datasheet, but still reference it as it's
   the closest match i could find on the internet.
 - add a bit on how i got the device.
 - add lspci -v output.
 - run checkpatch.pl and correct spelling.

v2 based on feedback from Greg KH:
 - use git send-email:
   - fix patch format.
   - have author == sender.

Niv Sardi (1):
  USB: serial: ch341: add new Product ID

 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3] USB: serial: ch341: add new Product ID
  2021-03-01 20:16 [PATCH v3 0/1] USB: serial: ch341: add new Product ID Niv Sardi
@ 2021-03-01 20:16 ` Niv Sardi
  2021-03-05  9:21   ` Johan Hovold
  0 siblings, 1 reply; 3+ messages in thread
From: Niv Sardi @ 2021-03-01 20:16 UTC (permalink / raw)
  To: linux-usb; +Cc: Niv Sardi

Add PID for CH340 that's found on cheap programmers.

The driver works flawlessly as soon as the new PID (0x9986) is added to it.
These look like ANU232MI but ship with a ch341 inside. They have no special
identifiers (mine only has the string "DB9D20130716" printed on the PCB and
nothing identifiable on the packaging. The merchant i bought it from 
doesn't sell these anymore).

the lsusb -v output is:
Bus 001 Device 009: ID 9986:7523  
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               1.10
  bDeviceClass          255 Vendor Specific Class
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0         8
  idVendor           0x9986 
  idProduct          0x7523 
  bcdDevice            2.54
  iManufacturer           0 
  iProduct                0 
  iSerial                 0 
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength       0x0027
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0x80
      (Bus Powered)
    MaxPower               96mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           3
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass      1 
      bInterfaceProtocol      2 
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x82  EP 2 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0020  1x 32 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0020  1x 32 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0008  1x 8 bytes
        bInterval               1

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
---
 drivers/usb/serial/ch341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 28deaaec581f..f26861246f65 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -86,6 +86,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x1a86, 0x7522) },
 	{ USB_DEVICE(0x1a86, 0x7523) },
 	{ USB_DEVICE(0x4348, 0x5523) },
+	{ USB_DEVICE(0x9986, 0x7523) },
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] USB: serial: ch341: add new Product ID
  2021-03-01 20:16 ` [PATCH v3] " Niv Sardi
@ 2021-03-05  9:21   ` Johan Hovold
  0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2021-03-05  9:21 UTC (permalink / raw)
  To: Niv Sardi; +Cc: linux-usb

On Mon, Mar 01, 2021 at 05:16:12PM -0300, Niv Sardi wrote:
> Add PID for CH340 that's found on cheap programmers.
> 
> The driver works flawlessly as soon as the new PID (0x9986) is added to it.
> These look like ANU232MI but ship with a ch341 inside. They have no special
> identifiers (mine only has the string "DB9D20130716" printed on the PCB and
> nothing identifiable on the packaging. The merchant i bought it from 
> doesn't sell these anymore).
> 
> the lsusb -v output is:
> Bus 001 Device 009: ID 9986:7523  

> Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>

Thanks for the update. Now applied and tagged for stable.

Johan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-05  9:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 20:16 [PATCH v3 0/1] USB: serial: ch341: add new Product ID Niv Sardi
2021-03-01 20:16 ` [PATCH v3] " Niv Sardi
2021-03-05  9:21   ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).