Re: [PATCH 1/3] usb: dwc2: Add default param to control power optimization.

Re: [PATCH 1/3] usb: dwc2: Add default param to control power optimization.

[Greg Kroah-Hartman]

On Fri, Mar 26, 2021 at 02:24:23PM +0400, Artur Petrosyan wrote:
> There are 3 power saving options supported in dwc2 core
> 1. Hibernation
> 2. Partial Power Down
> 3. Clock gating
> 
> To enable or disable the power saving features earlier users
> had to set "power_down" param to "0". However, "power_down"
> parameter is meant to and used for distinguishing between the
> power saving options.
> 
> So, if Hibernation is enabled then
> "power_down = 2"
> if Partial Power Down is enabled then
> "power_down = 1"
> if not Hibernation nor Partial Power Down are enabled then
> "power_down = 0".
> 
> Setting the "power_down" to "0" for disabling power saving
> options is not right because it is used to differentiate
> power saving options.
> 
> Therefor added a new parameter named "power_saving" which will
> be used only for enabling or disabling power saving modes.
> 
> NOTE: If Hibernation or Partial Power Down modes are disabled
> then by default Clock gating mode is used.
> 
> - Added a default param "power_saving" to enable or
>   disable hibernation or partial power down features.

But nothing changes this option?  So why does it matter?

> 
> - Printed hibernation param in hw_params_show and
>   power_saving param in params_show.

Please make this a separate patch for the hibernation option, as it has
nothing to do with this patch at all.

thanks,

greg k-h

Re: [PATCH 1/3] usb: dwc2: Add default param to control power optimization.

[Greg Kroah-Hartman]

On Wed, Mar 24, 2021 at 04:44:31PM +0000, Artur Petrosyan wrote:
> Hi Greg,
> 
> On 3/23/2021 15:24, Greg Kroah-Hartman wrote:
> > On Thu, Mar 18, 2021 at 10:12:46AM +0400, Artur Petrosyan wrote:
> >> - Added a default param "power_saving" to enable or
> >>    disable hibernation or partial power down features.
> >>
> >> - Printed hibernation param in hw_params_show and
> >>    power_saving param in params_show.
> > 
> > This says what you are doing, but not _why_ you are doing this.  Why is
> > this needed at all?
> > 
> > Please read the documentation for how to write a good changelog text for
> > when you resubmit this series.
> 
> Thank you for your reply. I have corrected changelog of the patch 
> according the documentation. Will submit in series.
> 
> > 
> > Also note that the emails were not "threaded", was that on purpose?
> Yes, the patches that were included in the "usb: dwc2: Fix and improve 
> power saving modes" which was submitted earlier were too large and 
> needed to be split up into smaller patches.
> We had a discussion about that with Felipe Balbi earlier. Here is the 
> link to the discussion thread 
> (https://marc.info/?l=linux-usb&m=160379651904064&w=2)
> So I did the split and obviously the cover letter and the subject were 
> changed therefor I have submitted the updates with this thread and 
> mentioned in the cover letter that these are continuation of the 
> previous patch set that was too large.

No, I mean you are not "threading" your emails so that they show up as
one after another all in the same email "thread".  Please use
git-send-email to do this, or some other tool.

thanks,

greg k-h

Re: [PATCH 1/3] usb: dwc2: Add default param to control power optimization.

[Artur Petrosyan]

Hi Greg,

On 3/23/2021 15:24, Greg Kroah-Hartman wrote:
> On Thu, Mar 18, 2021 at 10:12:46AM +0400, Artur Petrosyan wrote:
>> - Added a default param "power_saving" to enable or
>>    disable hibernation or partial power down features.
>>
>> - Printed hibernation param in hw_params_show and
>>    power_saving param in params_show.
> 
> This says what you are doing, but not _why_ you are doing this.  Why is
> this needed at all?
> 
> Please read the documentation for how to write a good changelog text for
> when you resubmit this series.

Thank you for your reply. I have corrected changelog of the patch 
according the documentation. Will submit in series.

> 
> Also note that the emails were not "threaded", was that on purpose?
Yes, the patches that were included in the "usb: dwc2: Fix and improve 
power saving modes" which was submitted earlier were too large and 
needed to be split up into smaller patches.
We had a discussion about that with Felipe Balbi earlier. Here is the 
link to the discussion thread 
(https://marc.info/?l=linux-usb&m=160379651904064&w=2)
So I did the split and obviously the cover letter and the subject were 
changed therefor I have submitted the updates with this thread and 
mentioned in the cover letter that these are continuation of the 
previous patch set that was too large.

> 
> thanks,
> 
> greg k-h
> 
Regards,
Artur

Re: [PATCH 1/3] usb: dwc2: Add default param to control power optimization.

[Greg Kroah-Hartman]

On Thu, Mar 18, 2021 at 10:12:46AM +0400, Artur Petrosyan wrote:
> - Added a default param "power_saving" to enable or
>   disable hibernation or partial power down features.
> 
> - Printed hibernation param in hw_params_show and
>   power_saving param in params_show.

This says what you are doing, but not _why_ you are doing this.  Why is
this needed at all?

Please read the documentation for how to write a good changelog text for
when you resubmit this series.

Also note that the emails were not "threaded", was that on purpose?

thanks,

greg k-h