From: Greg KH <gregkh@linuxfoundation.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: balbi@kernel.org, robh+dt@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, frowand.list@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
jackp@codeaurora.org, fntoth@gmail.com,
heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v10 2/6] usb: gadget: configfs: Check USB configuration before adding
Date: Thu, 17 Jun 2021 13:07:18 +0200 [thread overview]
Message-ID: <YMss5tFFBjokk1k6@kroah.com> (raw)
In-Reply-To: <1623923899-16759-3-git-send-email-wcheng@codeaurora.org>
On Thu, Jun 17, 2021 at 02:58:15AM -0700, Wesley Cheng wrote:
> Ensure that the USB gadget is able to support the configuration being
> added based on the number of endpoints required from all interfaces. This
> is for accounting for any bandwidth or space limitations.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> drivers/usb/gadget/configfs.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 15a607c..76b9983 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1374,6 +1374,7 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
> struct usb_function *f;
> struct usb_function *tmp;
> struct gadget_config_name *cn;
> + unsigned long ep_map = 0;
>
> if (gadget_is_otg(gadget))
> c->descriptors = otg_desc;
> @@ -1403,7 +1404,28 @@ static int configfs_composite_bind(struct usb_gadget *gadget,
> list_add(&f->list, &cfg->func_list);
> goto err_purge_funcs;
> }
> + if (f->fs_descriptors) {
> + struct usb_descriptor_header **d;
> +
> + d = f->fs_descriptors;
> + for (; *d; ++d) {
With this check, there really is not a need to check for
f->fs_descriptors above in the if statement, right?
> + struct usb_endpoint_descriptor *ep;
> + int addr;
> +
> + if ((*d)->bDescriptorType != USB_DT_ENDPOINT)
> + continue;
> +
> + ep = (struct usb_endpoint_descriptor *)*d;
> + addr = ((ep->bEndpointAddress & 0x80) >> 3) |
> + (ep->bEndpointAddress & 0x0f);
Don't we have direction macros for this type of check?
> + set_bit(addr, &ep_map);
> + }
What is this loop trying to do? Please document it as I can not figure
it out at all.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-17 11:07 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 9:58 [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-06-17 9:58 ` [PATCH v10 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-06-17 11:09 ` Greg KH
2021-06-22 5:27 ` Wesley Cheng
2021-06-17 9:58 ` [PATCH v10 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-06-17 11:07 ` Greg KH [this message]
2021-06-22 5:27 ` Wesley Cheng
2021-06-22 6:05 ` Greg KH
2021-06-23 9:38 ` Wesley Cheng
2021-06-23 11:35 ` Greg KH
2021-06-23 21:44 ` Wesley Cheng
2021-06-24 12:09 ` Greg KH
2021-06-17 9:58 ` [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-06-17 11:10 ` Greg KH
2021-06-22 5:27 ` Wesley Cheng
2021-06-22 6:06 ` Greg KH
2021-06-17 17:56 ` kernel test robot
2021-06-17 18:01 ` kernel test robot
2021-06-17 9:58 ` [PATCH v10 4/6] of: Add stub for of_add_property() Wesley Cheng
2021-06-17 9:58 ` [PATCH v10 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-06-17 11:12 ` Greg KH
2021-06-17 18:04 ` kernel test robot
2021-06-18 4:35 ` Jack Pham
2021-06-17 9:58 ` [PATCH v10 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
2021-06-17 21:01 ` [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Ferry Toth
2021-06-17 21:48 ` Wesley Cheng
[not found] ` <f5ed0ee7-e333-681f-0f1a-d0227562204b@gmail.com>
2021-06-17 22:25 ` Wesley Cheng
2021-06-19 12:40 ` Ferry Toth
2021-06-22 18:38 ` Wesley Cheng
2021-06-22 20:09 ` Ferry Toth
2021-06-22 22:00 ` Wesley Cheng
2021-06-22 22:12 ` Ferry Toth
2021-06-23 7:50 ` Wesley Cheng
2021-06-25 21:10 ` Ferry Toth
2021-06-25 21:19 ` Wesley Cheng
2021-06-25 22:31 ` Ferry Toth
2021-07-22 18:43 ` Ferry Toth
2021-07-23 6:59 ` Felipe Balbi
[not found] ` <d9aef50c-4bd1-4957-13d8-0b6a14b9fcd0@gmail.com>
2021-07-23 11:23 ` Felipe Balbi
2021-07-24 20:59 ` Ferry Toth
2021-07-24 21:19 ` Andy Shevchenko
2021-07-24 22:56 ` Ferry Toth
2021-07-25 6:05 ` Felipe Balbi
2021-07-25 13:32 ` Ferry Toth
2021-07-25 14:05 ` Felipe Balbi
2021-07-25 16:54 ` Ferry Toth
2021-07-26 5:57 ` Felipe Balbi
2021-07-26 14:33 ` Wesley Cheng
2021-07-26 21:51 ` Ferry Toth
2021-08-15 20:56 ` Ferry Toth
2021-08-16 5:18 ` Felipe Balbi
2021-08-17 22:00 ` Ferry Toth
2021-08-18 19:07 ` Ferry Toth
2021-08-19 7:51 ` Pavel Hofman
2021-08-19 20:10 ` Ferry Toth
2021-08-19 21:04 ` Pavel Hofman
2021-08-21 2:57 ` Thinh Nguyen
2021-08-22 20:10 ` Ferry Toth
2021-08-23 7:57 ` Pavel Hofman
2021-09-02 0:28 ` Jack Pham
2021-09-02 22:58 ` Thinh Nguyen
2021-08-22 19:43 ` Ferry Toth
2021-08-23 14:59 ` Pavel Hofman
2021-08-23 15:21 ` Andy Shevchenko
2021-08-23 15:34 ` Pavel Hofman
2021-08-23 18:54 ` Ferry Toth
2021-08-23 22:50 ` Thinh Nguyen
2021-08-24 5:39 ` Pavel Hofman
2021-08-24 13:44 ` Ferry Toth
[not found] ` <7ffab777-0f77-f949-f70f-7bf34c504381@gmail.com>
2021-08-26 1:18 ` Thinh Nguyen
2021-08-26 7:30 ` Ferry Toth
2021-08-26 13:35 ` Pavel Hofman
2021-08-19 7:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMss5tFFBjokk1k6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fntoth@gmail.com \
--cc=frowand.list@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).