linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Ferry Toth <fntoth@gmail.com>,
	Pavel Hofman <pavel.hofman@ivitera.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Wesley Cheng <wcheng@codeaurora.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"agross@kernel.org" <agross@kernel.org>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"frowand.list@gmail.com" <frowand.list@gmail.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"jackp@codeaurora.org" <jackp@codeaurora.org>,
	"heikki.krogerus@linux.intel.com"
	<heikki.krogerus@linux.intel.com>,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>
Subject: Re: [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting
Date: Thu, 26 Aug 2021 01:18:20 +0000	[thread overview]
Message-ID: <ff6d7385-a6d7-8920-dbe6-9018432392fa@synopsys.com> (raw)
In-Reply-To: <7ffab777-0f77-f949-f70f-7bf34c504381@gmail.com>

Ferry Toth wrote:
> Hi
> 
> Op 24-08-2021 om 07:39 schreef Pavel Hofman:
>>
>>
>> Dne 24. 08. 21 v 0:50 Thinh Nguyen napsal(a):
>>> Pavel Hofman wrote:
>>>>
>>>>
>>>> Dne 23. 08. 21 v 17:21 Andy Shevchenko napsal(a):
>>>>> On Mon, Aug 23, 2021 at 5:59 PM Pavel Hofman
>>>>> <pavel.hofman@ivitera.com> wrote:
>>>>>> Dne 22. 08. 21 v 21:43 Ferry Toth napsal(a):
>>>>>>> Op 19-08-2021 om 23:04 schreef Pavel Hofman:
>>>>>>>> Dne 19. 08. 21 v 22:10 Ferry Toth napsal(a):
>>>>>>>>> Op 19-08-2021 om 09:51 schreef Pavel Hofman:
>>>>>>>>>> Dne 18. 08. 21 v 21:07 Ferry Toth napsal(a):
>>>>>>>>>>> Op 18-08-2021 om 00:00 schreef Ferry Toth:
>>>>>
>>>>> ...
>>>>>
>>>>>>>>>>> So, where do we go from here?
>>>>>>>>>>
>>>>>>>>>> I know the patches have been tested on dwc2 (by me and
>>>>>>>>>> others).  I
>>>>>>>>>> do not know if Ruslan or Jerome tested them on dwc3 but probably
>>>>>>>>>> not. Ruslan has talked about RPi (my case too) and
>>>>>>>>>> BeagleboneBlack,
>>>>>>>>>> both with dwc2. Perhaps the dwc2 behaves a bit differently than
>>>>>>>>>> dwc3?
>>>>>>>>>>
>>>>>>>>>> The patches add a new EP-IN for async feedback. I am sorry I have
>>>>>>>>>> not followed your long thread (it started as unrelated to
>>>>>>>>>> uac). Does
>>>>>>>>>> the problem appear with f_uac1 or f_uac2? Please how have you
>>>>>>>>>> reached the above problem?
>>>>>>>>>
>>>>>>>>> I'm sorry too. I first believed the issue was related to the patch
>>>>>>>>> mentioned in the subject line.
>>>>>>>>>
>>>>>>>>> The problem appaers with f_uac2. I bost Edison_Arduino board in
>>>>>>>>> host
>>>>>>>>> mode (there is a switch allowing to select host/device mode). When
>>>>>>>>> flipping the switch to device mode udev run a script:
>>>>>>>>> But as I am using configfs (excerpt follows) and just disabling
>>>>>>>>> the
>>>>>>>>> last 2 line resolves the issue, I'm guessing uac2 is the issue. Or
>>>>>>>>> exceeding the available resources.
>>>>>>>>>
>>>>>>>>> # Create directory structure
>>>>>>>>> mkdir "${GADGET_BASE_DIR}"
>>>>>>>>> cd "${GADGET_BASE_DIR}"
>>>>>>>>> mkdir -p configs/c.1/strings/0x409
>>>>>>>>> mkdir -p strings/0x409
>>>>>>>>>
>>>>>>>>> # Serial device
>>>>>>>>> mkdir functions/gser.usb0
>>>>>>>>> ln -s functions/gser.usb0 configs/c.1/
>>>>>>>>> ###
>>>>>>>>>
>>>>>>>>> # Ethernet device
>>>>>>>>> mkdir functions/eem.usb0
>>>>>>>>> echo "${DEV_ETH_ADDR}" > functions/eem.usb0/dev_addr
>>>>>>>>> echo "${HOST_ETH_ADDR}" > functions/eem.usb0/host_addr
>>>>>>>>> ln -s functions/eem.usb0 configs/c.1/
>>>>>>>>>
>>>>>>>>> # Mass Storage device
>>>>>>>>> mkdir functions/mass_storage.usb0
>>>>>>>>> echo 1 > functions/mass_storage.usb0/stall
>>>>>>>>> echo 0 > functions/mass_storage.usb0/lun.0/cdrom
>>>>>>>>> echo 0 > functions/mass_storage.usb0/lun.0/ro
>>>>>>>>> echo 0 > functions/mass_storage.usb0/lun.0/nofua
>>>>>>>>> echo "${USBDISK}" > functions/mass_storage.usb0/lun.0/file
>>>>>>>>> ln -s functions/mass_storage.usb0 configs/c.1/
>>>>>>>>>
>>>>>>>>> # UAC2 device
>>>>>>>>> mkdir functions/uac2.usb0
>>>>>>>>> ln -s functions/uac2.usb0 configs/c.1
>>>>>>>>> ....
>>>>>>>>
>>>>>>>> As you say, could perhaps the reason be that the extra EP-IN
>>>>>>>> added in
>>>>>>>> those patches (previously 1, now 2 with the default config you use)
>>>>>>>> exceeds your EP-IN max count or available fifos somehow?  You
>>>>>>>> have a
>>>>>>>> number of functions initialized. If you change the load order of
>>>>>>>> the
>>>>>>>> functions, do you get the error later with a different function?
>>>>>>>> Just
>>>>>>>> guessing...
>>>>>>>>
>>>>>>>> You should be able to switch the default async EP-OUT (which
>>>>>>>> configures the new feedback EP-IN ) to adaptive EP-OUT (which
>>>>>>>> requires
>>>>>>>> no feedback EP) with c_sync=8 parameter of f_uac2.
>>>>>>>>
>>>>>>>> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.14-rc6/source/drivers/usb/gadget/function/f_uac2.c*L47__;Iw!!A4F2R9G_pg!LBySrM_zgMGV0x-zZ7nSrs54yJw1GlnpUVUVxdQE8PeszSMZ6OkFX8lSoigwRbWQzLcU$
>>>>>>>>
>>>>>>>>
>>>>>>>> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.14-rc6/source/drivers/usb/gadget/function/f_uac2.c*L830__;Iw!!A4F2R9G_pg!LBySrM_zgMGV0x-zZ7nSrs54yJw1GlnpUVUVxdQE8PeszSMZ6OkFX8lSoigwRfP5TdZC$
>>>>>>>>
>>>>>>>>
>>>>>>>> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.14-rc6/source/include/uapi/linux/usb/ch9.h*L453__;Iw!!A4F2R9G_pg!LBySrM_zgMGV0x-zZ7nSrs54yJw1GlnpUVUVxdQE8PeszSMZ6OkFX8lSoigwRejzMbWO$
>>>>>>>>
>>>>>>>>
>>>>>>>> Does that fix the problem?
>>>>>>>
>>>>>>> Not sure how to do that. Do you mean the module should have a
>>>>>>> parameter
>>>>>>> called c_sync? `modinfo` list no parameters for usb_f_uac2.
>>>>>>
>>>>>> Those are configfs params, not available in modinfo.
>>>>>>
>>>>>> I checked and the value is "adaptive"
>>>>>> https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.14-rc7/source/drivers/usb/gadget/function/f_uac2.c*L1312__;Iw!!A4F2R9G_pg!LBySrM_zgMGV0x-zZ7nSrs54yJw1GlnpUVUVxdQE8PeszSMZ6OkFX8lSoigwRTETcbsN$
>>>>>>
>>>>>
>>>>>
>>>>>> In your configfs script:
>>>>>
>>>>> Kernel shouldn't crash with any available set of configuration
>>>>> parameters, right? So, even if the parameter would fix the crash the
>>>>> series is buggy and has to be reverted in my opinion.
>>>>
>>>> Sure, no problem with reverting. I am just trying to start up some
>>>> troubleshooting. A resource exhaustion was mentioned here, that's why I
>>>> suggested a way to test the patch with the original number of endpoints
>>>> allocated. I do not get any crashes on my setup which uses fewer gadget
>>>> functions. That's why I asked what happens if the functions load order
>>>> is changed. I am afraid this thread is so complex that the actual
>>>> problem has been burried in the history.
>>>>
>>>
>>> As I pointed out previously, the crash is probably because of f_uac2
>>> prematurely freeing feedback request before its completion.
>>> usb_ep_dequeue() is asynchronous. dwc2() may treat it as a synchronous
>>> call so you didn't get a crash.
>>
>> Thanks for your hint, it greatly helps.
>>>>
>>>
>>> I'm not sure how easy it is for you to obtain/test a device with dwc3,
>>> but it would be great to also have it as part of your testing suite. :)
>>
>> Can you recommend a reasonably priced device with viable kernel
>> updates for the testing? Optionally with SS which you mentioned last
>> time? Thanks.
>>
> Edison-Arduino kit 2nd hand with display on ebay ~$100 :-)
> 

Ferry can correct me if I'm wrong, but I think Edison-Arduino kit only
supports up to highspeed. Regardless, Edison-Arduino seems to work well
with the latest Linux kernel.

I see that there are various development kits with rk3399 that supports
up to SuperSpeed at reasonable price, but I think they all require some
effort to bring up to the latest Linux kernel and in device mode.

Maybe Ferry/Felipe/anyone can provide more recommendations?

Thanks,
Thinh

  parent reply	other threads:[~2021-08-26  1:18 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  9:58 [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-06-17  9:58 ` [PATCH v10 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-06-17 11:09   ` Greg KH
2021-06-22  5:27     ` Wesley Cheng
2021-06-17  9:58 ` [PATCH v10 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-06-17 11:07   ` Greg KH
2021-06-22  5:27     ` Wesley Cheng
2021-06-22  6:05       ` Greg KH
2021-06-23  9:38         ` Wesley Cheng
2021-06-23 11:35           ` Greg KH
2021-06-23 21:44             ` Wesley Cheng
2021-06-24 12:09               ` Greg KH
2021-06-17  9:58 ` [PATCH v10 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-06-17 11:10   ` Greg KH
2021-06-22  5:27     ` Wesley Cheng
2021-06-22  6:06       ` Greg KH
2021-06-17 17:56   ` kernel test robot
2021-06-17 18:01   ` kernel test robot
2021-06-17  9:58 ` [PATCH v10 4/6] of: Add stub for of_add_property() Wesley Cheng
2021-06-17  9:58 ` [PATCH v10 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-06-17 11:12   ` Greg KH
2021-06-17 18:04   ` kernel test robot
2021-06-18  4:35     ` Jack Pham
2021-06-17  9:58 ` [PATCH v10 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
2021-06-17 21:01 ` [PATCH v10 0/6] Re-introduce TX FIFO resize for larger EP bursting Ferry Toth
2021-06-17 21:48   ` Wesley Cheng
     [not found]     ` <f5ed0ee7-e333-681f-0f1a-d0227562204b@gmail.com>
2021-06-17 22:25       ` Wesley Cheng
2021-06-19 12:40         ` Ferry Toth
2021-06-22 18:38           ` Wesley Cheng
2021-06-22 20:09             ` Ferry Toth
2021-06-22 22:00               ` Wesley Cheng
2021-06-22 22:12                 ` Ferry Toth
2021-06-23  7:50                   ` Wesley Cheng
2021-06-25 21:10                     ` Ferry Toth
2021-06-25 21:19                       ` Wesley Cheng
2021-06-25 22:31                         ` Ferry Toth
2021-07-22 18:43             ` Ferry Toth
2021-07-23  6:59               ` Felipe Balbi
     [not found]                 ` <d9aef50c-4bd1-4957-13d8-0b6a14b9fcd0@gmail.com>
2021-07-23 11:23                   ` Felipe Balbi
2021-07-24 20:59                     ` Ferry Toth
2021-07-24 21:19                       ` Andy Shevchenko
2021-07-24 22:56                         ` Ferry Toth
2021-07-25  6:05                       ` Felipe Balbi
2021-07-25 13:32                         ` Ferry Toth
2021-07-25 14:05                           ` Felipe Balbi
2021-07-25 16:54                             ` Ferry Toth
2021-07-26  5:57                               ` Felipe Balbi
2021-07-26 14:33                                 ` Wesley Cheng
2021-07-26 21:51                                   ` Ferry Toth
2021-08-15 20:56                                 ` Ferry Toth
2021-08-16  5:18                                   ` Felipe Balbi
2021-08-17 22:00                                     ` Ferry Toth
2021-08-18 19:07                                       ` Ferry Toth
2021-08-19  7:51                                         ` Pavel Hofman
2021-08-19 20:10                                           ` Ferry Toth
2021-08-19 21:04                                             ` Pavel Hofman
2021-08-21  2:57                                               ` Thinh Nguyen
2021-08-22 20:10                                                 ` Ferry Toth
2021-08-23  7:57                                                   ` Pavel Hofman
2021-09-02  0:28                                                 ` Jack Pham
2021-09-02 22:58                                                   ` Thinh Nguyen
2021-08-22 19:43                                               ` Ferry Toth
2021-08-23 14:59                                                 ` Pavel Hofman
2021-08-23 15:21                                                   ` Andy Shevchenko
2021-08-23 15:34                                                     ` Pavel Hofman
2021-08-23 18:54                                                       ` Ferry Toth
2021-08-23 22:50                                                       ` Thinh Nguyen
2021-08-24  5:39                                                         ` Pavel Hofman
2021-08-24 13:44                                                           ` Ferry Toth
     [not found]                                                           ` <7ffab777-0f77-f949-f70f-7bf34c504381@gmail.com>
2021-08-26  1:18                                                             ` Thinh Nguyen [this message]
2021-08-26  7:30                                                               ` Ferry Toth
2021-08-26 13:35                                                               ` Pavel Hofman
2021-08-19  7:55                                         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff6d7385-a6d7-8920-dbe6-9018432392fa@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fntoth@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jackp@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=robh+dt@kernel.org \
    --cc=ruslan.bilovol@gmail.com \
    --cc=wcheng@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).