* UCSI failing due to probe() getting version 0
@ 2021-08-05 14:04 Oliver Neukum
2021-08-11 13:23 ` Heikki Krogerus
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2021-08-05 14:04 UTC (permalink / raw)
To: USB list; +Cc: heikki.krogerus
Hi,
I am trying this on a new laptop, but I am getting a result I do not
understand.
ucsi_acpi_probe() is called, but ucsi_register() fails with -ENODEV,
because ucsi->version is 0.
If I dump the ucsi_acpi buffer I get:
00 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
And, frankly I do not understand that. Why have the ACPI device
but show version number 0?
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: UCSI failing due to probe() getting version 0
2021-08-05 14:04 UCSI failing due to probe() getting version 0 Oliver Neukum
@ 2021-08-11 13:23 ` Heikki Krogerus
2021-08-11 14:47 ` Oliver Neukum
0 siblings, 1 reply; 4+ messages in thread
From: Heikki Krogerus @ 2021-08-11 13:23 UTC (permalink / raw)
To: Oliver Neukum; +Cc: USB list
On Thu, Aug 05, 2021 at 04:04:03PM +0200, Oliver Neukum wrote:
> Hi,
>
> I am trying this on a new laptop, but I am getting a result I do not
> understand.
> ucsi_acpi_probe() is called, but ucsi_register() fails with -ENODEV,
> because ucsi->version is 0.
>
> If I dump the ucsi_acpi buffer I get:
>
> 00 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>
> And, frankly I do not understand that. Why have the ACPI device
> but show version number 0?
Because of BIOS bugs.
Ideally we should be able to rely on the _STA method of the ACPI
device, but unfortunately with UCSI we can't rely on that alone. On
some systems the BIOS claims that the device is enabled (based on
_STA) even when the platform doesn't actually support UCSI at all.
If you remove the check, does the driver work?
Br,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: UCSI failing due to probe() getting version 0
2021-08-11 13:23 ` Heikki Krogerus
@ 2021-08-11 14:47 ` Oliver Neukum
2021-08-12 8:10 ` Heikki Krogerus
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2021-08-11 14:47 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: USB list
On 11.08.21 15:23, Heikki Krogerus wrote:
Hi,
> Because of BIOS bugs.
>
> Ideally we should be able to rely on the _STA method of the ACPI
> device, but unfortunately with UCSI we can't rely on that alone. On
> some systems the BIOS claims that the device is enabled (based on
> _STA) even when the platform doesn't actually support UCSI at all.
>
> If you remove the check, does the driver work?
Unfortunately, no it does not:
[ 4.657715] ACPI Error: No handler for Region [ECSI]
(00000000862594d8) [EmbeddedControl] (20210604/evregion-135)
[ 4.657734] ACPI Error: Region EmbeddedControl (ID=3) has no handler
(20210604/exfldio-265)
[ 4.657754] ACPI Error: Aborting method \_SB.UBTC.ECWR due to
previous error (AE_NOT_EXIST) (20210604/psparse-531)
[ 4.658812] ACPI Error: Aborting method \_SB.UBTC._DSM due to
previous error (AE_NOT_EXIST) (20210604/psparse-531)
[ 4.659646] ACPI: \_SB_.UBTC: failed to evaluate _DSM (0x6)
[ 4.659657] ucsi_acpi USBC000:00: ucsi_acpi_dsm: failed to evaluate
_DSM 1
[ 4.659665] ucsi_acpi USBC000:00: failed to reset PPM!
[ 4.659683] ucsi_acpi USBC000:00: PPM init failed (-5)
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: UCSI failing due to probe() getting version 0
2021-08-11 14:47 ` Oliver Neukum
@ 2021-08-12 8:10 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2021-08-12 8:10 UTC (permalink / raw)
To: Oliver Neukum; +Cc: USB list
On Wed, Aug 11, 2021 at 04:47:13PM +0200, Oliver Neukum wrote:
>
> On 11.08.21 15:23, Heikki Krogerus wrote:
> Hi,
> > Because of BIOS bugs.
> >
> > Ideally we should be able to rely on the _STA method of the ACPI
> > device, but unfortunately with UCSI we can't rely on that alone. On
> > some systems the BIOS claims that the device is enabled (based on
> > _STA) even when the platform doesn't actually support UCSI at all.
> >
> > If you remove the check, does the driver work?
>
> Unfortunately, no it does not:
OK, so your laptop does not support UCSI even though the BIOS claims
it does.
thanks,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-12 8:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 14:04 UCSI failing due to probe() getting version 0 Oliver Neukum
2021-08-11 13:23 ` Heikki Krogerus
2021-08-11 14:47 ` Oliver Neukum
2021-08-12 8:10 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).