[PATCH v3] usb: dwc3: gadget: clear gadget pointer after exit

[PATCH v3] usb: dwc3: gadget: clear gadget pointer after exit

[Linyu Yuan]

change device release function to clear gadget pointer,
it is just a cleanup change.

Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
---
v2: fix comment from Greg Kroah-Hartman and improve commit log
v3: change commit log, it is just a cleanup change

 drivers/usb/dwc3/gadget.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 804b505..e2ab5f6 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4188,9 +4188,10 @@ static int dwc3_gadget_get_irq(struct dwc3 *dwc)
 
 static void dwc_gadget_release(struct device *dev)
 {
-	struct usb_gadget *gadget = container_of(dev, struct usb_gadget, dev);
+	struct dwc3 *dwc = dev_get_platdata(dev);
 
-	kfree(gadget);
+	kfree(dwc->gadget);
+	dwc->gadget = NULL;
 }
 
 /**
-- 
2.7.4

Re: [PATCH v3] usb: dwc3: gadget: clear gadget pointer after exit

[Greg Kroah-Hartman]

On Thu, Sep 09, 2021 at 07:12:43PM +0800, Linyu Yuan wrote:
> change device release function to clear gadget pointer,
> it is just a cleanup change.
> 
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> v2: fix comment from Greg Kroah-Hartman and improve commit log
> v3: change commit log, it is just a cleanup change
> 
>  drivers/usb/dwc3/gadget.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 804b505..e2ab5f6 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4188,9 +4188,10 @@ static int dwc3_gadget_get_irq(struct dwc3 *dwc)
>  
>  static void dwc_gadget_release(struct device *dev)
>  {
> -	struct usb_gadget *gadget = container_of(dev, struct usb_gadget, dev);
> +	struct dwc3 *dwc = dev_get_platdata(dev);
>  
> -	kfree(gadget);
> +	kfree(dwc->gadget);
> +	dwc->gadget = NULL;
>  }
>  
>  /**
> -- 
> 2.7.4
> 

This does not do any functional change, and is not a "cleanup" at all.

If you have code that requires this, wonderful, please submit that as
well, but we can not take changes that do not have in-tree users,
otherwise we could never maintain the kernel at all.  Make this a patch
series with your usage as well.

thanks,

greg k-h