* [PATCH] usb: usb-skeleton: remove obsolete comment
@ 2021-09-21 21:41 Philipp Hortmann
2021-09-22 5:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Hortmann @ 2021-09-21 21:41 UTC (permalink / raw)
To: gregkh, linux-usb, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: It's generally not useful to have the filename in the file
7: FILE: drivers/usb/usb-skeleton.c:7:
+ * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
Deleting both lines as the -2.6.3- makes the reader belief this is an
unusable old file and the -rewritten to be easier ...- is only of value for
the reader that knows what the driver was before.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/usb/usb-skeleton.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index d87deee3e26e..91da019a1171 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -4,8 +4,6 @@
*
* Copyright (C) 2001-2004 Greg Kroah-Hartman (greg@kroah.com)
*
- * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
- * but has been rewritten to be easier to read and use.
*/
#include <linux/kernel.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: usb-skeleton: remove obsolete comment
2021-09-21 21:41 [PATCH] usb: usb-skeleton: remove obsolete comment Philipp Hortmann
@ 2021-09-22 5:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-09-22 5:56 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: linux-usb, linux-kernel
On Tue, Sep 21, 2021 at 11:41:47PM +0200, Philipp Hortmann wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: It's generally not useful to have the filename in the file
> 7: FILE: drivers/usb/usb-skeleton.c:7:
> + * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
>
> Deleting both lines as the -2.6.3- makes the reader belief this is an
> unusable old file and the -rewritten to be easier ...- is only of value for
> the reader that knows what the driver was before.
>
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
> drivers/usb/usb-skeleton.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index d87deee3e26e..91da019a1171 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -4,8 +4,6 @@
> *
> * Copyright (C) 2001-2004 Greg Kroah-Hartman (greg@kroah.com)
> *
> - * This driver is based on the 2.6.3 version of drivers/usb/usb-skeleton.c
> - * but has been rewritten to be easier to read and use.
No, this is fine to keep in the source code, checkpatch is telling you
something else in the above "hint".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-22 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 21:41 [PATCH] usb: usb-skeleton: remove obsolete comment Philipp Hortmann
2021-09-22 5:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).