Re: [PATCH v2] USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter

Re: [PATCH v2] USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter

[Johan Hovold]

On Tue, Sep 21, 2021 at 07:54:46PM +0200, Uwe Brandt wrote:
> Add the USB serial device ID for the GW Instek GDM-834x Digital Multimeter
> 
> Signed-off-by: Uwe Brandt <uwe.brandt@gmail.com>
> ---
> Hi Johan,
> 
> included is a patch to make the GW Instek GDM-834x Multimeter accessible
> via ttyUSBx
> https://www.gwinstek.com/en-global/products/detail/GDM-8342_GDM-8341
> 
> lsusb output:
> Bus 001 Device 002: ID 2184:0030 GW Instek GDM834X VCP PORT
> 
> dmesg output:
> [ 1102.650572] usb 1-2: cp210x converter now attached to ttyUSB0

Thanks for the v2, looks good now!

When you switched to sending from the t-online account the commit author
mail address also changed so that it no longer matches the Signed-off-by
address. We generally prefer them to match and tools like
scripts/checkpatch.pl also warns about this.

I changed back the author mail address to you gmail address which you
used in v1 when applying. Let me know if you prefer it the other way
round instead and I'll drop the patch so you can resend.

For next time, git-send-email can usually deal with this by inserting
a From: line at the start of the patch body if configured correctly (or
you can do so manually).

Also note that the second v2 you sent last night appeared to be
whitespace damaged again for some reason (empty lines inserted between
every line). But this one from Tuesday night was fine and I didn't
notice any other differences.

> ---
>   drivers/usb/serial/cp210x.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 66a6ac50a4..7c6a4f6948 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -233,6 +233,7 @@ static const struct usb_device_id id_table[] = {
>   	{ USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power Supply */
>   	{ USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM Controller */
>   	{ USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix */
> +	{ USB_DEVICE(0x2184, 0x0030) }, /* GW Instek GDM-834x Digital Multimeter */
>   	{ USB_DEVICE(0x2626, 0xEA60) }, /* Aruba Networks 7xxx USB Serial Console */
>   	{ USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */
>   	{ USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */

Now applied.

Johan