* [PATCH] usbnet: sanity check for maxpacket
@ 2021-10-20 9:17 Oliver Neukum
2021-10-20 10:32 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2021-10-20 9:17 UTC (permalink / raw)
To: syzkaller-bugs, netdev, linux-usb, davem, kuba
Cc: Oliver Neukum, syzbot+76bb1d34ffa0adc03baa
maxpacket of 0 makes no sense and oopdses as we need to divide
by it. Give up.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
---
drivers/net/usb/usbnet.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 840c1c2ab16a..396f5e677bf0 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1788,6 +1788,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
if (!dev->rx_urb_size)
dev->rx_urb_size = dev->hard_mtu;
dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
+ if (dev->maxpacket == 0)
+ /* that is a broken device */
+ goto out4;
/* let userspace know we have a random address */
if (ether_addr_equal(net->dev_addr, node_id))
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbnet: sanity check for maxpacket
2021-10-20 9:17 [PATCH] usbnet: sanity check for maxpacket Oliver Neukum
@ 2021-10-20 10:32 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2021-10-20 10:32 UTC (permalink / raw)
To: Oliver Neukum
Cc: syzkaller-bugs, netdev, linux-usb, davem, kuba,
syzbot+76bb1d34ffa0adc03baa
On Wed, Oct 20, 2021 at 11:17:33AM +0200, Oliver Neukum wrote:
> maxpacket of 0 makes no sense and oopdses as we need to divide
typo: oopses
> by it. Give up.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: syzbot+76bb1d34ffa0adc03baa@syzkaller.appspotmail.com
> ---
> drivers/net/usb/usbnet.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 840c1c2ab16a..396f5e677bf0 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -1788,6 +1788,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> if (!dev->rx_urb_size)
> dev->rx_urb_size = dev->hard_mtu;
> dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
> + if (dev->maxpacket == 0)
> + /* that is a broken device */
> + goto out4;
I'd prefer brackets here since it's a multi-line block. Or just drop the
comment.
>
> /* let userspace know we have a random address */
> if (ether_addr_equal(net->dev_addr, node_id))
Other than that, looks good:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 9:17 [PATCH] usbnet: sanity check for maxpacket Oliver Neukum
2021-10-20 10:32 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).