* [PATCH v4] USB: host: isp116x: Check for null res pointer
@ 2021-12-21 1:56 Jiasheng Jiang
2021-12-21 6:17 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2021-12-21 1:56 UTC (permalink / raw)
To: ok, gregkh; +Cc: linux-usb, linux-kernel, Jiasheng Jiang
And I correct my commit message because platform_get_resource returns
null if fails.
Here is it.
The return value of platform_get_resource() could be null when there is
no suitable resource.
So it should be better to check it to avoid the use of null pointer in
release_mem_region().
Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v3 -> v4
*Change 1. Just skip the use of null pointer instead of directly return.
*Change 2. Add the driver name in the subject line.
*Change 3. Correct commit message.
---
drivers/usb/host/isp116x-hcd.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 8835f6bd528e..aacaf6e2ddca 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1541,10 +1541,13 @@ static int isp116x_remove(struct platform_device *pdev)
iounmap(isp116x->data_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- release_mem_region(res->start, 2);
+ if (res)
+ release_mem_region(res->start, 2);
+
iounmap(isp116x->addr_reg);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- release_mem_region(res->start, 2);
+ if (res)
+ release_mem_region(res->start, 2);
usb_put_hcd(hcd);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] USB: host: isp116x: Check for null res pointer
2021-12-21 1:56 [PATCH v4] USB: host: isp116x: Check for null res pointer Jiasheng Jiang
@ 2021-12-21 6:17 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-12-21 6:17 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: ok, linux-usb, linux-kernel
On Tue, Dec 21, 2021 at 09:56:58AM +0800, Jiasheng Jiang wrote:
> And I correct my commit message because platform_get_resource returns
> null if fails.
> Here is it.
> The return value of platform_get_resource() could be null when there is
> no suitable resource.
> So it should be better to check it to avoid the use of null pointer in
> release_mem_region().
>
> Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v3 -> v4
>
> *Change 1. Just skip the use of null pointer instead of directly return.
> *Change 2. Add the driver name in the subject line.
> *Change 3. Correct commit message.
> ---
> drivers/usb/host/isp116x-hcd.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
*plonk*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-21 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 1:56 [PATCH v4] USB: host: isp116x: Check for null res pointer Jiasheng Jiang
2021-12-21 6:17 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).