* [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function
@ 2023-03-19 14:10 Tom Rix
2023-03-20 11:59 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-19 14:10 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh, matthias.bgg,
angelogioacchino.delregno, nathan, ndesaulniers
Cc: linux-usb, linux-kernel, linux-arm-kernel, linux-mediatek, llvm, Tom Rix
clang with W=1 reports
drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
'mt6360_tcpc_read16' [-Werror,-Wunused-function]
static inline int mt6360_tcpc_read16(struct regmap *regmap,
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 1b7c31278ebb..6fa8fd5c8041 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
int irq;
};
-static inline int mt6360_tcpc_read16(struct regmap *regmap,
- unsigned int reg, u16 *val)
-{
- return regmap_raw_read(regmap, reg, val, sizeof(u16));
-}
-
static inline int mt6360_tcpc_write16(struct regmap *regmap,
unsigned int reg, u16 val)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function
2023-03-19 14:10 [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function Tom Rix
@ 2023-03-20 11:59 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2023-03-20 11:59 UTC (permalink / raw)
To: Tom Rix
Cc: linux, gregkh, matthias.bgg, angelogioacchino.delregno, nathan,
ndesaulniers, linux-usb, linux-kernel, linux-arm-kernel,
linux-mediatek, llvm
On Sun, Mar 19, 2023 at 10:10:53AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
> 'mt6360_tcpc_read16' [-Werror,-Wunused-function]
> static inline int mt6360_tcpc_read16(struct regmap *regmap,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 1b7c31278ebb..6fa8fd5c8041 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
> int irq;
> };
>
> -static inline int mt6360_tcpc_read16(struct regmap *regmap,
> - unsigned int reg, u16 *val)
> -{
> - return regmap_raw_read(regmap, reg, val, sizeof(u16));
> -}
> -
> static inline int mt6360_tcpc_write16(struct regmap *regmap,
> unsigned int reg, u16 val)
> {
> --
> 2.27.0
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 14:10 [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function Tom Rix
2023-03-20 11:59 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).