* [PATCH v1] usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked
@ 2024-04-23 20:25 RD Babiera
2024-04-25 9:50 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: RD Babiera @ 2024-04-23 20:25 UTC (permalink / raw)
To: heikki.krogerus, gregkh
Cc: badhri, linux-usb, linux-kernel, RD Babiera, stable
tcpm_queue_vdm_unlocked queues VDMs over SOP regardless of input
parameter tx_sop_type. Fix tcpm_queue_vdm() call.
Fixes: 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")
Cc: stable@vger.kernel.org
Signed-off-by: RD Babiera <rdbabiera@google.com>
---
Patch applies starting at 6.9 tree.
---
drivers/usb/typec/tcpm/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index c26fb70c3ec6..3f38e7c7d13f 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -1565,7 +1565,7 @@ static void tcpm_queue_vdm_unlocked(struct tcpm_port *port, const u32 header,
const u32 *data, int cnt, enum tcpm_transmit_type tx_sop_type)
{
mutex_lock(&port->lock);
- tcpm_queue_vdm(port, header, data, cnt, TCPC_TX_SOP);
+ tcpm_queue_vdm(port, header, data, cnt, tx_sop_type);
mutex_unlock(&port->lock);
}
base-commit: 684e9f5f97eb4b7831298ffad140d5c1d426ff27
--
2.44.0.769.g3c40516874-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked
2024-04-23 20:25 [PATCH v1] usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked RD Babiera
@ 2024-04-25 9:50 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2024-04-25 9:50 UTC (permalink / raw)
To: RD Babiera; +Cc: gregkh, badhri, linux-usb, linux-kernel, stable
On Tue, Apr 23, 2024 at 08:25:46PM +0000, RD Babiera wrote:
> tcpm_queue_vdm_unlocked queues VDMs over SOP regardless of input
> parameter tx_sop_type. Fix tcpm_queue_vdm() call.
>
> Fixes: 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")
> Cc: stable@vger.kernel.org
> Signed-off-by: RD Babiera <rdbabiera@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Patch applies starting at 6.9 tree.
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index c26fb70c3ec6..3f38e7c7d13f 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1565,7 +1565,7 @@ static void tcpm_queue_vdm_unlocked(struct tcpm_port *port, const u32 header,
> const u32 *data, int cnt, enum tcpm_transmit_type tx_sop_type)
> {
> mutex_lock(&port->lock);
> - tcpm_queue_vdm(port, header, data, cnt, TCPC_TX_SOP);
> + tcpm_queue_vdm(port, header, data, cnt, tx_sop_type);
> mutex_unlock(&port->lock);
> }
>
>
> base-commit: 684e9f5f97eb4b7831298ffad140d5c1d426ff27
> --
> 2.44.0.769.g3c40516874-goog
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-25 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 20:25 [PATCH v1] usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked RD Babiera
2024-04-25 9:50 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).