From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: USB list <linux-usb@vger.kernel.org>
Subject: Re: f_mass_storage vs drivers/target
Date: Thu, 22 Aug 2019 14:58:23 +1000 [thread overview]
Message-ID: <cc5030dcc06868fe93af4899be004c5a802d783b.camel@kernel.crashing.org> (raw)
In-Reply-To: <9c7090713374e80b6c26a9dabb753c5b35b9c93d.camel@kernel.crashing.org>
On Thu, 2019-08-22 at 10:10 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2019-08-21 at 10:25 -0400, Alan Stern wrote:
> > On Wed, 21 Aug 2019, Benjamin Herrenschmidt wrote:
> >
> > > Hi folks !
> > >
> > > It seems that f_mass_storage duplicates (well maybe predates too..)
> >
> > a
> > > lot of what's in drivers/target.
> > >
> > > Anybody working on implementing a new version of f_mass_storage
> >
> > that
> > > is layered upon drivers/target instead ? That would bring quite a
> >
> > lot
> > > of additional functionality.
> >
> > That's what f_tcm does.
> >
> > Alan Stern
>
> Haha nice, I never noticed it :-)
Ah lovely ... the 338x fails in EP autoconf with f_tcm, digging...
While digging I found this gem:
/* USB3380: use same address for usb and hardware endpoints */
snprintf(name, sizeof(name), "ep%d%s", usb_endpoint_num(desc),
usb_endpoint_dir_in(desc) ? "in" : "out");
ep = gadget_find_ep_by_name(_gadget, name);
if (ep && usb_gadget_ep_match_desc(_gadget, ep, desc, ep_comp))
return ep;
Any idea what's that supposed to achieve ?
When ep_match is called, usb_endpoint_num() hasn't been set yet so
it's always 0 and always fails... or am I missing something ?
Cheers,
Ben.
next prev parent reply other threads:[~2019-08-22 4:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 3:38 f_mass_storage vs drivers/target Benjamin Herrenschmidt
2019-08-21 9:32 ` Greg KH
2019-08-21 14:25 ` Alan Stern
2019-08-22 0:10 ` Benjamin Herrenschmidt
2019-08-22 4:58 ` Benjamin Herrenschmidt [this message]
2019-08-22 5:14 ` Benjamin Herrenschmidt
2019-08-22 5:48 ` Benjamin Herrenschmidt
2019-08-22 17:30 ` Alan Stern
2019-08-23 0:40 ` Benjamin Herrenschmidt
2019-08-23 15:21 ` Alan Stern
2019-08-26 2:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc5030dcc06868fe93af4899be004c5a802d783b.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).