From: Cixi Geng <cixi.geng@linux.dev>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
zhang.lyra@gmail.com, arnd@arndb.de, tony@atomide.com,
felipe.balbi@linux.intel.com, paul@crapouillou.net,
linus.walleij@linaro.org, cixi.geng1@unisoc.com,
gengcixi@gmail.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [RFC PATCH v1] usb/phy add sprd ums512 usbphy
Date: Sat, 18 Mar 2023 23:15:33 +0800 [thread overview]
Message-ID: <e872037e88af46ee4a329a2bee39806533365018.camel@linux.dev> (raw)
In-Reply-To: <ZA7DUH+qJyMmWBq5@kroah.com>
On Mon, 2023-03-13 at 07:31 +0100, Greg KH wrote:
> On Mon, Mar 13, 2023 at 01:14:38AM +0800, Cixi Geng wrote:
> > From: Cixi Geng <cixi.geng1@unisoc.com>
> >
> > This driver is support USB2 phy for Spreadtrum UMS512 SOC's,
> >
> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
>
> Why is this "RFC"? What is left to do on it to be accepted?
this is just the driver code, lack of dt-bindings
>
> > ---
> > drivers/usb/phy/Kconfig | 10 +
> > drivers/usb/phy/Makefile | 1 +
> > drivers/usb/phy/phy-sprd-ums512.c | 511
> > ++++++++++++++++++++++++++++++
> > drivers/usb/phy/phy-sprd-ums512.h | 39 +++
>
> Why do you need a .h file for a single .c file? Please just put them
> all together into one file.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-03-18 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 17:14 [RFC PATCH v1] usb/phy add sprd ums512 usbphy Cixi Geng
2023-03-13 6:31 ` Greg KH
2023-03-18 15:15 ` Cixi Geng [this message]
2023-03-13 9:11 ` Baolin Wang
2023-03-18 15:37 ` Cixi Geng
2023-03-21 2:03 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e872037e88af46ee4a329a2bee39806533365018.camel@linux.dev \
--to=cixi.geng@linux.dev \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=cixi.geng1@unisoc.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gengcixi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=paul@crapouillou.net \
--cc=tony@atomide.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).