* [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO
@ 2019-10-21 14:18 Arnd Bergmann
2019-10-21 14:19 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-10-21 14:18 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: Arnd Bergmann, Neil Armstrong, Martin Blumenstingl, Felipe Balbi,
Roger Quadros, Lee Jones, linux-usb, linux-kernel
After many randconfig builds, one configuration caused a link
error with dwc3-meson-g12a lacking the regmap-mmio code:
drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'
Add the select statement that we have for all other users
of that dependency.
Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/dwc3/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index 89abc6078703..556a876c7896 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -102,6 +102,7 @@ config USB_DWC3_MESON_G12A
depends on ARCH_MESON || COMPILE_TEST
default USB_DWC3
select USB_ROLE_SWITCH
+ select REGMAP_MMIO
help
Support USB2/3 functionality in Amlogic G12A platforms.
Say 'Y' or 'M' if you have one such device.
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO
2019-10-21 14:18 [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO Arnd Bergmann
@ 2019-10-21 14:19 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2019-10-21 14:19 UTC (permalink / raw)
To: Arnd Bergmann, Felipe Balbi, Greg Kroah-Hartman
Cc: Martin Blumenstingl, Felipe Balbi, Roger Quadros, Lee Jones,
linux-usb, linux-kernel
On 21/10/2019 16:18, Arnd Bergmann wrote:
> After many randconfig builds, one configuration caused a link
> error with dwc3-meson-g12a lacking the regmap-mmio code:
>
> drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
> dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'
>
> Add the select statement that we have for all other users
> of that dependency.
>
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/dwc3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 89abc6078703..556a876c7896 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -102,6 +102,7 @@ config USB_DWC3_MESON_G12A
> depends on ARCH_MESON || COMPILE_TEST
> default USB_DWC3
> select USB_ROLE_SWITCH
> + select REGMAP_MMIO
> help
> Support USB2/3 functionality in Amlogic G12A platforms.
> Say 'Y' or 'M' if you have one such device.
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-21 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 14:18 [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO Arnd Bergmann
2019-10-21 14:19 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).