[PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[James Buren]

These drive enclosures have firmware bugs that make it impossible to mount
a new virtual ISO image after Linux ejects the old one if the device is
locked by Linux. Windows bypasses this problem by the fact that they do
not lock the device. Add a quirk to disable device locking for these
drive enclosures.

Signed-off-by: James Buren <braewoods+lkml@braewoods.net>
---
 drivers/usb/storage/unusual_devs.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index c6b3fcf90180..4267b13962e1 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -415,6 +415,16 @@ UNUSUAL_DEV(  0x04cb, 0x0100, 0x0000, 0x2210,
 		"FinePix 1400Zoom",
 		USB_SC_UFI, USB_PR_DEVICE, NULL, US_FL_FIX_INQUIRY | US_FL_SINGLE_LUN),
 
+/*
+ * Reported by James Buren <braewoods+lkml@braewoods.net>
+ * Virtual ISOs cannot be remounted if ejected while the device is locked
+ * Disable locking to mimic Windows behavior that bypasses the issue
+ */
+UNUSUAL_DEV(  0x04c5, 0x2028, 0x0001, 0x0001,
+		"iODD",
+		"2531/2541",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE),
+
 /*
  * Reported by Ondrej Zary <linux@zary.sk>
  * The device reports one sector more and breaks when that sector is accessed
-- 
2.25.1

Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[braewoods]

Please disregard this patch. I updated it in the next thread because it 
was out of order in this one.

Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[Alan Stern]

On Fri, Oct 15, 2021 at 09:54:45AM +0200, Greg KH wrote:
> On Fri, Oct 15, 2021 at 01:29:20AM -0500, braewoods@braewoods.net wrote:
> > On 2021-10-13 21:20, Alan Stern wrote:
> > > In the future, you should always include a version number in the email
> > > Subject: line (for example, "[PATCH v2]") so that readers will know
> > > which patch is which.  And you should include, here just below the "---"
> > > line, a description of how this version differs from the previous
> > > version.  See the email archives for examples of multi-version patches.
> > > 
> > > Nevertheless, this looks okay.
> > > 
> > > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> > 
> > Noted. I'll do that for future patches. On a side note, any idea how long it
> > normally takes to get a simple patch like this committed? I've had mixed
> > experiences with getting feedback on patches. Sometimes my patches just get
> > totally ignored.
> 
> Depends on the subsystem and the patch submitted.

Greg tends to be quite good at merging patches in a timely manner.  They 
generally are committed within a few weeks.

In this case, should the patch also be added to the -stable kernels?

Alan Stern

> Also always use scripts/get_maintainer.pl to properly copy the needed
> maintainers and mailing lists.  Sometimes patches get lost in the noise
> if the right people are not copied.
> 
> thanks,
> 
> greg k-h

Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[Greg KH]

On Fri, Oct 15, 2021 at 01:29:20AM -0500, braewoods@braewoods.net wrote:
> On 2021-10-13 21:20, Alan Stern wrote:
> > In the future, you should always include a version number in the email
> > Subject: line (for example, "[PATCH v2]") so that readers will know
> > which patch is which.  And you should include, here just below the "---"
> > line, a description of how this version differs from the previous
> > version.  See the email archives for examples of multi-version patches.
> > 
> > Nevertheless, this looks okay.
> > 
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> 
> Noted. I'll do that for future patches. On a side note, any idea how long it
> normally takes to get a simple patch like this committed? I've had mixed
> experiences with getting feedback on patches. Sometimes my patches just get
> totally ignored.

Depends on the subsystem and the patch submitted.

Also always use scripts/get_maintainer.pl to properly copy the needed
maintainers and mailing lists.  Sometimes patches get lost in the noise
if the right people are not copied.

thanks,

greg k-h

Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[braewoods]

On 2021-10-13 21:20, Alan Stern wrote:
> In the future, you should always include a version number in the email
> Subject: line (for example, "[PATCH v2]") so that readers will know
> which patch is which.  And you should include, here just below the 
> "---"
> line, a description of how this version differs from the previous
> version.  See the email archives for examples of multi-version patches.
> 
> Nevertheless, this looks okay.
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Noted. I'll do that for future patches. On a side note, any idea how 
long it normally takes to get a simple patch like this committed? I've 
had mixed experiences with getting feedback on patches. Sometimes my 
patches just get totally ignored.

Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[Alan Stern]

On Wed, Oct 13, 2021 at 08:55:04PM -0500, James Buren wrote:
> These drive enclosures have firmware bugs that make it impossible to mount
> a new virtual ISO image after Linux ejects the old one if the device is
> locked by Linux. Windows bypasses this problem by the fact that they do
> not lock the device. Add a quirk to disable device locking for these
> drive enclosures.
> 
> Signed-off-by: James Buren <braewoods+lkml@braewoods.net>
> ---

In the future, you should always include a version number in the email 
Subject: line (for example, "[PATCH v2]") so that readers will know 
which patch is which.  And you should include, here just below the "---" 
line, a description of how this version differs from the previous 
version.  See the email archives for examples of multi-version patches.

Nevertheless, this looks okay.

Acked-by: Alan Stern <stern@rowland.harvard.edu>

>  drivers/usb/storage/unusual_devs.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index c6b3fcf90180..29191d33c0e3 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -406,6 +406,16 @@ UNUSUAL_DEV(  0x04b8, 0x0602, 0x0110, 0x0110,
>  		"785EPX Storage",
>  		USB_SC_SCSI, USB_PR_BULK, NULL, US_FL_SINGLE_LUN),
>  
> +/*
> + * Reported by James Buren <braewoods+lkml@braewoods.net>
> + * Virtual ISOs cannot be remounted if ejected while the device is locked
> + * Disable locking to mimic Windows behavior that bypasses the issue
> + */
> +UNUSUAL_DEV(  0x04c5, 0x2028, 0x0001, 0x0001,
> +		"iODD",
> +		"2531/2541",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE),
> +
>  /*
>   * Not sure who reported this originally but
>   * Pavel Machek <pavel@ucw.cz> reported that the extra US_FL_SINGLE_LUN
> -- 
> 2.25.1

[PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[James Buren]

These drive enclosures have firmware bugs that make it impossible to mount
a new virtual ISO image after Linux ejects the old one if the device is
locked by Linux. Windows bypasses this problem by the fact that they do
not lock the device. Add a quirk to disable device locking for these
drive enclosures.

Signed-off-by: James Buren <braewoods+lkml@braewoods.net>
---
 drivers/usb/storage/unusual_devs.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index c6b3fcf90180..29191d33c0e3 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -406,6 +406,16 @@ UNUSUAL_DEV(  0x04b8, 0x0602, 0x0110, 0x0110,
 		"785EPX Storage",
 		USB_SC_SCSI, USB_PR_BULK, NULL, US_FL_SINGLE_LUN),
 
+/*
+ * Reported by James Buren <braewoods+lkml@braewoods.net>
+ * Virtual ISOs cannot be remounted if ejected while the device is locked
+ * Disable locking to mimic Windows behavior that bypasses the issue
+ */
+UNUSUAL_DEV(  0x04c5, 0x2028, 0x0001, 0x0001,
+		"iODD",
+		"2531/2541",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE),
+
 /*
  * Not sure who reported this originally but
  * Pavel Machek <pavel@ucw.cz> reported that the extra US_FL_SINGLE_LUN
-- 
2.25.1