From: Jiri Kosina <jikos@kernel.org>
To: Andrej Shadura <andrew.shadura@collabora.co.uk>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
kernel@collabora.com, Theodore Ts'o <tytso@mit.edu>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
linux-crypto@vger.kernel.org
Subject: [v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Wed, 10 Apr 2019 14:02:49 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1904101400520.9803@cbobk.fhfr.pm> (raw)
On Mon, 1 Apr 2019, Andrej Shadura wrote:
> U2F Zero supports custom commands for blinking the LED and getting data
> from the internal hardware RNG. Expose the blinking function as a LED
> device, and the internal hardware RNG as an HWRNG so that it can be used
> to feed the enthropy pool.
So I still am not really happy about this being wired up into generic HID
although it's really a USB driver, but we've discussed that already, and I
don't see any option that'd work substantially better in this case,
especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Kosina <jikos@kernel.org>
To: Andrej Shadura <andrew.shadura@collabora.co.uk>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
kernel@collabora.com, Theodore Ts'o <tytso@mit.edu>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG
Date: Wed, 10 Apr 2019 14:02:49 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1904101400520.9803@cbobk.fhfr.pm> (raw)
Message-ID: <20190410120249.-BIGf4ajtkRBKO_Ale8ajD6WgJcPm6WTqPsDbst-ZjA@z> (raw)
In-Reply-To: <20190401124200.17331-1-andrew.shadura@collabora.co.uk>
On Mon, 1 Apr 2019, Andrej Shadura wrote:
> U2F Zero supports custom commands for blinking the LED and getting data
> from the internal hardware RNG. Expose the blinking function as a LED
> device, and the internal hardware RNG as an HWRNG so that it can be used
> to feed the enthropy pool.
So I still am not really happy about this being wired up into generic HID
although it's really a USB driver, but we've discussed that already, and I
don't see any option that'd work substantially better in this case,
especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
thanks!
--
Jiri Kosina
SUSE Labs
next prev reply other threads:[~2019-04-10 12:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 12:42 [v3] HID: add driver for U2F Zero built-in LED and RNG Andrej Shadura
2019-04-10 12:02 ` Jiri Kosina [this message]
2019-04-10 12:02 ` [PATCH v3] " Jiri Kosina
2019-04-11 9:58 ` [v3] " Benjamin Tissoires
2019-04-11 9:58 ` [PATCH v3] " Benjamin Tissoires
2019-04-11 10:35 ` [v3] " Jiri Kosina
2019-04-11 10:35 ` [PATCH v3] " Jiri Kosina
2019-04-11 11:52 ` [v3] " Andrej Shadura
2019-04-11 11:52 ` [PATCH v3] " Andrej Shadura
2019-04-17 14:43 ` [v3] " Jiri Kosina
2019-04-17 14:43 ` [PATCH v3] " Jiri Kosina
2019-04-17 14:47 ` [v3] " Andrej Shadura
2019-04-17 14:47 ` [PATCH v3] " Andrej Shadura
2019-10-03 7:19 ` Andrej Shadura
2019-10-03 15:25 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1904101400520.9803@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=anarsoul@gmail.com \
--cc=andrew.shadura@collabora.co.uk \
--cc=andrzej.p@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).