From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: wim@linux-watchdog.org, linux-imx@nxp.com,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: imx7ulp: Fix missing conversion of imx7ulp_wdt_enable()
Date: Wed, 20 Nov 2019 07:44:14 -0800 [thread overview]
Message-ID: <00cb2b20-0793-77ad-d80c-11f8a8ec972a@roeck-us.net> (raw)
In-Reply-To: <20191120140916.25001-1-festevam@gmail.com>
On 11/20/19 6:09 AM, Fabio Estevam wrote:
> Since commit 747d88a1a88c1b ("watchdog: imx7ulp: Pass the wdog instance in
> imx7ulp_wdt_enable()") imx7ulp_wdt_enable() accepts a watchdog_device
> structure, so fix one instance that missed such conversion.
>
> This also fixes the following sparse warning:
>
> drivers/watchdog/imx7ulp_wdt.c:115:31: warning: incorrect type in argument 1 (different address spaces)
> drivers/watchdog/imx7ulp_wdt.c:115:31: expected struct watchdog_device *wdog
> drivers/watchdog/imx7ulp_wdt.c:115:31: got void [noderef] <asn:2>*base
>
> Fixes: 747d88a1a88c1 ("watchdog: imx7ulp: Pass the wdog instance inimx7ulp_wdt_enable()")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/imx7ulp_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c
> index 0a87c6f4bab2..11b9e7c6b7f5 100644
> --- a/drivers/watchdog/imx7ulp_wdt.c
> +++ b/drivers/watchdog/imx7ulp_wdt.c
> @@ -112,7 +112,7 @@ static int imx7ulp_wdt_restart(struct watchdog_device *wdog,
> {
> struct imx7ulp_wdt_device *wdt = watchdog_get_drvdata(wdog);
>
> - imx7ulp_wdt_enable(wdt->base, true);
> + imx7ulp_wdt_enable(wdog, true);
> imx7ulp_wdt_set_timeout(&wdt->wdd, 1);
>
> /* wait for wdog to fire */
>
prev parent reply other threads:[~2019-11-20 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:09 [PATCH] watchdog: imx7ulp: Fix missing conversion of imx7ulp_wdt_enable() Fabio Estevam
2019-11-20 15:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00cb2b20-0793-77ad-d80c-11f8a8ec972a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=festevam@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).