From: Guenter Roeck <linux@roeck-us.net>
To: PeterYin <peteryin.openbmc@gmail.com>
Cc: patrick@stwcx.xyz, Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/4] drivers: watchdog: ast2500 and ast2600 support bootstatus
Date: Tue, 9 Apr 2024 11:08:10 -0700 [thread overview]
Message-ID: <01a07242-22ca-4abe-80f9-72ac4de93fb7@roeck-us.net> (raw)
In-Reply-To: <47835475-36de-4682-84ae-0163d45d0bac@gmail.com>
On Wed, Apr 10, 2024 at 12:28:44AM +0800, PeterYin wrote:
[ ... ]
>
> Hi Guenter,
> Could you help me understand the definition of WDIOF_CARDRESET in the
> kernel? If it resets the CPU, should all values be reset to default? Should
Documentation/watchdog/watchdog-api.rst says:
"Card previously reset the CPU"
This is a bit historic and was probably defined when watchdogs were
not typically integrated. The appropriate description, applied to
current watchdog devices, would be something like "The most recent
reset was triggered by this watchdog".
Not sure I understand "If it resets the CPU...". It doesn't _do_
anything, it just reports if the most recent reset was triggered
by the watchdog.
> we check the POR (RstPwr Power on reset SRST# flag) flag in SCU 0x74
> register bit 0 in ast2600?
>
Only if it indicates that the most recent reset was triggered by the
watchdog.
Guenter
prev parent reply other threads:[~2024-04-09 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 2:22 [PATCH v6 0/4] drivers: watchdog: ast2500 and ast2600 support bootstatus Peter Yin
2024-03-28 2:22 ` [PATCH v6 1/4] ARM: dts: aspeed: Add the AST2500 WDT with SCU register Peter Yin
2024-03-28 2:22 ` [PATCH v6 2/4] ARM: dts: aspeed: Add the AST2600 " Peter Yin
2024-03-28 2:22 ` [PATCH v6 3/4] dt-bindings: watchdog: aspeed-wdt: Add aspeed,scu Peter Yin
2024-04-01 13:56 ` Rob Herring
2024-04-02 12:09 ` Andrew Jeffery
2024-04-03 9:18 ` PeterYin
2024-04-04 1:50 ` Andrew Jeffery
2024-03-28 2:22 ` [PATCH v6 4/4] drivers: watchdog: ast2500 and ast2600 support bootstatus Peter Yin
2024-04-09 16:28 ` PeterYin
2024-04-09 18:08 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a07242-22ca-4abe-80f9-72ac4de93fb7@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=peteryin.openbmc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).