From: Guenter Roeck <linux@roeck-us.net>
To: YueHaibing <yuehaibing@huawei.com>,
wim@linux-watchdog.org, andrew@lunn.ch
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] watchdog: tqmx86_wdt: Fix build error
Date: Fri, 6 Dec 2019 06:05:13 -0800 [thread overview]
Message-ID: <1c31d0e5-37f9-4608-3af3-ba94f3b764e9@roeck-us.net> (raw)
In-Reply-To: <20191206124259.25880-1-yuehaibing@huawei.com>
On 12/6/19 4:42 AM, YueHaibing wrote:
> If TQMX86_WDT is y and WATCHDOG_CORE is m, building fails:
>
> drivers/watchdog/tqmx86_wdt.o: In function `tqmx86_wdt_probe':
> tqmx86_wdt.c:(.text+0x46e): undefined reference to `watchdog_init_timeout'
> tqmx86_wdt.c:(.text+0x4e0): undefined reference to `devm_watchdog_register_device'
>
> Select WATCHDOG_CORE to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e3c21e088f89 ("watchdog: tqmx86: Add watchdog driver for the IO controller")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 1679e0d..20bd967 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1444,6 +1444,7 @@ config SMSC37B787_WDT
> config TQMX86_WDT
> tristate "TQ-Systems TQMX86 Watchdog Timer"
> depends on X86
> + select WATCHDOG_CORE
> help
> This is the driver for the hardware watchdog timer in the TQMX86 IO
> controller found on some of their ComExpress Modules.
>
prev parent reply other threads:[~2019-12-06 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 12:42 [PATCH -next] watchdog: tqmx86_wdt: Fix build error YueHaibing
2019-12-06 14:05 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c31d0e5-37f9-4608-3af3-ba94f3b764e9@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).