From: Lee Jones <lee.jones@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
mazziesaccount@gmail.com, heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, robh+dt@kernel.org,
mark.rutland@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
sre@kernel.org, lgirdwood@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, wim@linux-watchdog.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-watchdog@vger.kernel.org, bogdan-petru.chircu-mare@nxp.com
Subject: Re: [PATCH v9 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block
Date: Thu, 14 Feb 2019 08:18:49 +0000 [thread overview]
Message-ID: <20190214081849.GI1863@dell> (raw)
In-Reply-To: <f11554b9-1842-13bc-7ceb-ca7589eb4518@roeck-us.net>
On Wed, 13 Feb 2019, Guenter Roeck wrote:
> On 2/13/19 5:37 AM, Matti Vaittinen wrote:
> > Initial support for watchdog block included in ROHM BD70528
> > power management IC.
> >
> > Configurations for low power states are still to be checked.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >
> > I maintained the ack from Guenter as only change is to use function
> > exported by MFD instead of pointer to function provided by MFD. Please
> > let me know if this is not Ok.
> >
>
> NP. With functions exported by MFD, my choice would have been to handle
> locking there as well with respective locking/unlocking functions exported.
> But that is your call to make, not mine.
FWIW, I agree.
[...]
Lots of superfluous quoting here mate. Better to snip it off IMHO.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-14 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 13:27 [PATCH v9 0/8] support ROHM BD70528 PMIC Matti Vaittinen
2019-02-13 13:28 ` [PATCH v9 1/8] mfd: regulator: clk: split rohm-bd718x7.h Matti Vaittinen
2019-02-13 13:29 ` [PATCH v9 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core Matti Vaittinen
2019-02-13 13:29 ` [PATCH v9 3/8] clk: bd718x7: Support ROHM BD70528 clk block Matti Vaittinen
2019-02-13 17:43 ` Stephen Boyd
2019-02-13 13:33 ` [PATCH v9 4/8] devicetree: bindings: Document first ROHM BD70528 bindings Matti Vaittinen
2019-02-13 13:34 ` [PATCH v9 5/8] gpio: Initial support for ROHM bd70528 GPIO block Matti Vaittinen
2019-02-14 8:00 ` Linus Walleij
2019-02-14 8:29 ` Matti Vaittinen
2019-02-14 12:38 ` Matti Vaittinen
2019-02-13 13:35 ` [PATCH v9 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC Matti Vaittinen
2019-02-13 13:36 ` [PATCH v9 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block Matti Vaittinen
2019-02-13 13:37 ` [PATCH v9 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block Matti Vaittinen
2019-02-13 15:09 ` Guenter Roeck
2019-02-14 8:18 ` Lee Jones [this message]
2019-02-14 8:23 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214081849.GI1863@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=bogdan-petru.chircu-mare@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).