From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, kernel@pengutronix.de
Subject: Re: What to set in struct watchdog_device::bootstatus?
Date: Thu, 9 May 2019 21:25:10 +0200 [thread overview]
Message-ID: <20190509192510.m6o7d63u7e4fs22h@pengutronix.de> (raw)
In-Reply-To: <20190220201408.gcgsg43uonwc4ucs@pengutronix.de>
Hello Guenter,
On Wed, Feb 20, 2019 at 09:14:08PM +0100, Uwe Kleine-König wrote:
> In a custom kernel patch stack I found a patch that uses (apart from
> WDIOF_CARDRESET also) WDIOF_POWERUNDER and WDIOF_EXTERN1 to
> differentiate the different reset causes. Now that you told using this
> is wrong, I wonder how these are supposed to be used instead; and there
> are a few more that according to
> Documentation/watchdog/watchdog-kernel-api.txt might be used to set
> bootstatus. Are these a relic? What do these signal?
I'm still interested in an answer here. While it is currently not
possible to "fix" the custom kernel as some other software that is
already shipping depends on this. Still I'd like to know the details
here to maybe suggest an alternative for the longterm future.
> IMHO there is a patch opportunity waiting to improve the documenation
> :-) Or maybe even change watchdog_get_status() to ensure that only
> WDIOF_CARDRESET, WDIOF_MAGICCLOSE and WDIOF_KEEPALIVEPING can be set?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-05-09 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 10:52 What to set in struct watchdog_device::bootstatus? Uwe Kleine-König
2019-02-08 14:05 ` Guenter Roeck
2019-02-20 20:14 ` Uwe Kleine-König
2019-05-09 19:25 ` Uwe Kleine-König [this message]
2019-05-10 3:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509192510.m6o7d63u7e4fs22h@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).