From: Guenter Roeck <linux@roeck-us.net>
To: Melin Tomas <tomas.melin@vaisala.com>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] watchdog: cadence_wdt: Group struct member init statements
Date: Tue, 9 Jul 2019 13:16:22 -0700 [thread overview]
Message-ID: <20190709201622.GC27937@roeck-us.net> (raw)
In-Reply-To: <20190709200801.42313-4-tomas.melin@vaisala.com>
On Tue, Jul 09, 2019 at 08:09:06PM +0000, Melin Tomas wrote:
> Move init statement and remove stray comment.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/cadence_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index a0d7666e7d20..0bdb275d904a 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -330,6 +330,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
> }
>
> cdns_wdt_device = &wdt->cdns_wdt_device;
> + cdns_wdt_device->parent = dev;
> cdns_wdt_device->info = &cdns_wdt_info;
> cdns_wdt_device->ops = &cdns_wdt_ops;
> cdns_wdt_device->timeout = CDNS_WDT_DEFAULT_TIMEOUT;
> @@ -356,9 +357,6 @@ static int cdns_wdt_probe(struct platform_device *pdev)
> }
> }
>
> - /* Initialize the members of cdns_wdt structure */
> - cdns_wdt_device->parent = dev;
> -
> watchdog_init_timeout(cdns_wdt_device, wdt_timeout, dev);
> watchdog_set_nowayout(cdns_wdt_device, nowayout);
> watchdog_stop_on_reboot(cdns_wdt_device);
> --
> 2.17.2
>
prev parent reply other threads:[~2019-07-09 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 20:09 [PATCH v3 0/4] watchdog: cadence_wdt: Support all available prescaler values Melin Tomas
2019-07-09 20:09 ` [PATCH v3 1/4] watchdog: cadence_wdt: Move clock detection earlier in probe Melin Tomas
2019-07-09 20:15 ` Guenter Roeck
2019-07-09 20:09 ` [PATCH v3 2/4] watchdog: cadence_wdt: Calculate actual timeout limits Melin Tomas
2019-07-09 20:14 ` Guenter Roeck
2019-07-09 20:09 ` [PATCH v3 4/4] watchdog: cadence_wdt: Support all available prescaler values Melin Tomas
2019-07-09 20:21 ` Guenter Roeck
2019-07-09 20:49 ` Melin Tomas
2019-07-09 21:07 ` Guenter Roeck
2019-07-10 19:20 ` Melin Tomas
2019-07-10 20:39 ` Guenter Roeck
2019-07-11 20:10 ` Melin Tomas
2019-07-09 20:09 ` [PATCH v3 3/4] watchdog: cadence_wdt: Group struct member init statements Melin Tomas
2019-07-09 20:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709201622.GC27937@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=tomas.melin@vaisala.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).