From: Guenter Roeck <linux@roeck-us.net>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: cadence: Do not show error in case of deferred probe
Date: Tue, 8 Oct 2019 08:22:20 -0700 [thread overview]
Message-ID: <20191008152220.GB15540@roeck-us.net> (raw)
In-Reply-To: <d3e295d5ba79f453b4aa4128c4fa63fbd6c16920.1570544944.git.michal.simek@xilinx.com>
On Tue, Oct 08, 2019 at 04:29:10PM +0200, Michal Simek wrote:
> There is no reason to show error message if clocks are not ready yet.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> drivers/watchdog/cadence_wdt.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 76d855ce25f3..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -335,8 +335,10 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>
> wdt->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(wdt->clk)) {
> - dev_err(dev, "input clock not found\n");
> - return PTR_ERR(wdt->clk);
> + ret = PTR_ERR(wdt->clk);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> + return ret;
> }
>
> ret = clk_prepare_enable(wdt->clk);
> --
> 2.17.1
>
prev parent reply other threads:[~2019-10-08 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 14:29 [PATCH] watchdog: cadence: Do not show error in case of deferred probe Michal Simek
2019-10-08 15:22 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008152220.GB15540@roeck-us.net \
--to=linux@roeck-us.net \
--cc=git@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).