From: Rob Herring <robh@kernel.org>
To: freddy.hsin@mediatek.com
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
linux@roeck-us.net, matthias.bgg@gmail.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, Chang-An.Chen@mediatek.com,
wsd_upstream@mediatek.com
Subject: Re: [PATCH v1 4/4] dt-binding: power: reset: Add documentation for MTK RGU (Reset Gernation Unit) reboot driver
Date: Thu, 5 Dec 2019 13:08:21 -0600 [thread overview]
Message-ID: <20191205190821.GA25233@bogus> (raw)
In-Reply-To: <1574746490-625-5-git-send-email-freddy.hsin@mediatek.com>
On Tue, Nov 26, 2019 at 01:34:50PM +0800, freddy.hsin@mediatek.com wrote:
> From: Freddy Hsin <freddy.hsin@mediatek.com>
>
> Add documentation for MTK RGU (Reset Generation Unit) reboot driver.
>
> Signed-off-by: Freddy Hsin <freddy.hsin@mediatek.com>
> ---
> .../devicetree/bindings/power/reset/mtk-reboot.txt | 30 ++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/reset/mtk-reboot.txt
>
> diff --git a/Documentation/devicetree/bindings/power/reset/mtk-reboot.txt b/Documentation/devicetree/bindings/power/reset/mtk-reboot.txt
> new file mode 100644
> index 0000000..708d351
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/mtk-reboot.txt
> @@ -0,0 +1,30 @@
> +Generic MTK RGU mapped register reset driver
> +
> +This is a reset driver using toprgu to map its non-volatile register.
> +The reset is generally performed with a write to the non-volatile register
> +defined by the register map pointed by toprgu reference plus the offset
> +with the mask defined in the reboot-mode node.
> +
> +Required properties:
> +- compatible: should contain "toprgu-reboot-mode"
What's wrong with syscon-reboot-mode?
> +- regmap: this is phandle to the register map node
Make this node a child node of the phandle and get rid of this.
> +- offset: offset in the register map for the reboot-mode register (in bytes)
> +- mask: the reset value written to the reboot register (32 bit access)
> +
> +Examples:
> + reboot-mode {
> + compatible = "toprgu-reboot-mode";
> + regmap = <&toprgu>;
> + offset = <0x24>;
> + mask = <0xF>;
> + };
> +
> +Optional properties - reboot mode value that will keep in toprgu nonrst RG:
> +- mode-charger = <BOOT_CHARGER>;
> +- mode-recovery = <BOOT_RECOVERY>;
> +- mode-bootloader = <BOOT_BOOTLOADER>;
> +- mode-dm-verity-dev-corrupt = <BOOT_DM_VERITY>;
> +- mode-kpoc = <BOOT_KPOC>;
> +- mode-ddr-reserve = <BOOT_DDR_RSVD>;
> +- mode-meta = <BOOT_META>;
> +- mode-rpmbpk = <BOOT_RPMBPK>;
> --
> 1.7.9.5
prev parent reply other threads:[~2019-12-05 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 5:34 [PATCH v1 0/4] Support MTK reboot mode driver freddy.hsin
2019-11-26 5:34 ` [PATCH v1 1/4] power: reset: add " freddy.hsin
2019-11-26 5:34 ` [PATCH v1 2/4] watchdog: populate reboot mode node in toprgu node of MTK RGU (Reset Generation Unit) freddy.hsin
2019-11-26 12:18 ` Guenter Roeck
2019-11-26 5:34 ` [PATCH v1 3/4] soc: mediatek: add reboot-mode header freddy.hsin
2019-11-26 5:34 ` [PATCH v1 4/4] dt-binding: power: reset: Add documentation for MTK RGU (Reset Gernation Unit) reboot driver freddy.hsin
2019-12-05 19:08 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205190821.GA25233@bogus \
--to=robh@kernel.org \
--cc=Chang-An.Chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=freddy.hsin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).