Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: pm8916_wdt: Add system sleep callbacks
Date: Tue, 11 Feb 2020 07:51:04 -0800
Message-ID: <20200211155104.GA824@roeck-us.net> (raw)
In-Reply-To: <1581435483-6796-1-git-send-email-loic.poulain@linaro.org>

On Tue, Feb 11, 2020 at 04:38:03PM +0100, Loic Poulain wrote:
> Add suspend and resume pm operations.
> Tested on dragonboard-410c.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/pm8916_wdt.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/watchdog/pm8916_wdt.c b/drivers/watchdog/pm8916_wdt.c
> index 1213179..0937b8d3 100644
> --- a/drivers/watchdog/pm8916_wdt.c
> +++ b/drivers/watchdog/pm8916_wdt.c
> @@ -192,6 +192,7 @@ static int pm8916_wdt_probe(struct platform_device *pdev)
>  	wdt->wdev.timeout = PM8916_WDT_DEFAULT_TIMEOUT;
>  	wdt->wdev.pretimeout = 0;
>  	watchdog_set_drvdata(&wdt->wdev, wdt);
> +	platform_set_drvdata(pdev, wdt);
>  
>  	watchdog_init_timeout(&wdt->wdev, 0, dev);
>  	pm8916_wdt_configure_timers(&wdt->wdev);
> @@ -199,6 +200,29 @@ static int pm8916_wdt_probe(struct platform_device *pdev)
>  	return devm_watchdog_register_device(dev, &wdt->wdev);
>  }
>  
> +static int __maybe_unused pm8916_wdt_suspend(struct device *dev)
> +{
> +	struct pm8916_wdt *wdt = dev_get_drvdata(dev);
> +
> +	if (watchdog_active(&wdt->wdev))
> +		return pm8916_wdt_stop(&wdt->wdev);
> +
> +	return 0;
> +}
> +
> +static int __maybe_unused pm8916_wdt_resume(struct device *dev)
> +{
> +	struct pm8916_wdt *wdt = dev_get_drvdata(dev);
> +
> +	if (watchdog_active(&wdt->wdev))
> +		return pm8916_wdt_start(&wdt->wdev);
> +
> +	return 0;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(pm8916_wdt_pm_ops, pm8916_wdt_suspend,
> +			 pm8916_wdt_resume);
> +
>  static const struct of_device_id pm8916_wdt_id_table[] = {
>  	{ .compatible = "qcom,pm8916-wdt" },
>  	{ }
> @@ -210,6 +234,7 @@ static struct platform_driver pm8916_wdt_driver = {
>  	.driver = {
>  		.name = "pm8916-wdt",
>  		.of_match_table = of_match_ptr(pm8916_wdt_id_table),
> +		.pm = &pm8916_wdt_pm_ops,
>  	},
>  };
>  module_platform_driver(pm8916_wdt_driver);
> -- 
> 2.7.4
> 

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 15:38 Loic Poulain
2020-02-11 15:51 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211155104.GA824@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git