From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>, Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
<linux-mips@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property
Date: Tue, 19 May 2020 00:42:00 +0300 [thread overview]
Message-ID: <20200518214200.cmkzyzzwxm4kotte@mobilestation> (raw)
In-Reply-To: <20200518204037.GA4909@bogus>
On Mon, May 18, 2020 at 02:40:37PM -0600, Rob Herring wrote:
> On Sun, May 10, 2020 at 01:58:03PM +0300, Serge Semin wrote:
> > In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false,
> > a custom timeout periods are used to preset the timer counter. In
> > this case that periods should be specified in a new "snps,watchdog-tops"
> > property of the DW watchdog dts node.
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: linux-mips@vger.kernel.org
> >
> > ---
> >
> > Rob, I had to remove your Reviewed-by tag, since the patch needed
> > to be updated a bit (see changelog).
> >
> > Changelog v2:
> > - Rearrange SoBs.
> > - Move $ref to the root level of the "snps,watchdog-tops" property
> > so does the constraints.
> > - Add default TOP values array.
> > - Discard the label definition from the new bindings example.
> > ---
> > .../bindings/watchdog/snps,dw-wdt.yaml | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > index 5bf6dc6377f3..cc741fb5a685 100644
> > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > @@ -39,6 +39,24 @@ properties:
> > description: Phandle to the DW Watchdog reset lane
> > maxItems: 1
> >
> > + snps,watchdog-tops:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description: |
> > + DW APB Watchdog custom timer intervals - Timeout Period ranges (TOPs).
> > + Each TOP is a number loaded into the watchdog counter at the moment of
> > + the timer restart. The counter decrementing happens each tick of the
> > + reference clock. Therefore the TOPs array is equivalent to an array of
> > + the timer expiration intervals supported by the DW APB Watchdog. Note
> > + DW APB Watchdog IP-core might be synthesized with fixed TOP values,
> > + in which case this property is unnecessary with default TOPs utilized.
> > + default: [0x0001000 0x0002000 0x0004000 0x0008000
> > + 0x0010000 0x0020000 0x0040000 0x0080000
> > + 0x0100000 0x0200000 0x0400000 0x0800000
> > + 0x1000000 0x2000000 0x4000000 0x8000000]
> > + items:
> > + minItems: 16
> > + maxItems: 16
>
> Drop 'items' and move these up a level. That may have given you some
> issues, but I made some fixes recently.
Ok. Thanks.
-Sergey
>
> With that,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> Rob
next prev parent reply other threads:[~2020-05-18 21:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:27 [PATCH 0/7] watchdog: dw_wdt: Take Baikal-T1 DW WDT peculiarities into account Sergey.Semin
2020-05-10 10:58 ` [PATCH v2 " Serge Semin
2020-05-10 10:58 ` [PATCH v2 1/7] dt-bindings: watchdog: Convert DW WDT binding to DT schema Serge Semin
2020-05-18 20:35 ` Rob Herring
2020-05-10 10:58 ` [PATCH v2 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks Serge Semin
2020-05-11 8:25 ` Sergei Shtylyov
2020-05-11 8:28 ` Sergei Shtylyov
2020-05-12 17:16 ` Serge Semin
2020-05-18 20:36 ` Rob Herring
2020-05-10 10:58 ` [PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property Serge Semin
2020-05-18 20:40 ` Rob Herring
2020-05-18 21:42 ` Serge Semin [this message]
2020-05-10 10:58 ` [PATCH v2 4/7] watchdog: dw_wdt: Support devices with non-fixed TOP values Serge Semin
2020-05-10 10:58 ` [PATCH v2 5/7] watchdog: dw_wdt: Support devices with asynch clocks Serge Semin
2020-05-10 10:58 ` [PATCH v2 6/7] watchdog: dw_wdt: Add pre-timeouts support Serge Semin
2020-05-10 10:58 ` [PATCH v2 7/7] watchdog: dw_wdt: Add DebugFS files Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518214200.cmkzyzzwxm4kotte@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).