From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] watchdog: rti: Simplify with dev_err_probe()
Date: Tue, 1 Sep 2020 13:19:10 -0700 [thread overview]
Message-ID: <20200901201910.GC143133@roeck-us.net> (raw)
In-Reply-To: <20200901153141.18960-3-krzk@kernel.org>
On Tue, Sep 01, 2020 at 05:31:41PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ---
>
> It is unusual to expect deferred probe from pm_runtime_get()...
> ---
> drivers/watchdog/rti_wdt.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index 705e8f7523e8..836319cbaca9 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -205,11 +205,8 @@ static int rti_wdt_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> clk = clk_get(dev, NULL);
> - if (IS_ERR(clk)) {
> - if (PTR_ERR(clk) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get clock\n");
> - return PTR_ERR(clk);
> - }
> + if (IS_ERR(clk))
> + return dev_err_probe(dev, PTR_ERR(clk), "failed to get clock\n");
>
> wdt->freq = clk_get_rate(clk);
>
> @@ -230,11 +227,8 @@ static int rti_wdt_probe(struct platform_device *pdev)
>
> pm_runtime_enable(dev);
> ret = pm_runtime_get_sync(dev);
> - if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "runtime pm failed\n");
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "runtime pm failed\n");
>
> platform_set_drvdata(pdev, wdt);
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-01 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 15:31 [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-01 15:31 ` [PATCH 2/3] watchdog: davinci: " Krzysztof Kozlowski
2020-09-01 15:50 ` Guenter Roeck
2020-09-01 20:19 ` Guenter Roeck
2020-09-01 15:31 ` [PATCH 3/3] watchdog: rti: " Krzysztof Kozlowski
2020-09-01 15:50 ` Guenter Roeck
2020-09-01 20:19 ` Guenter Roeck [this message]
2020-09-01 15:49 ` [PATCH 1/3] watchdog: cadence: " Guenter Roeck
2020-10-02 16:31 ` Krzysztof Kozlowski
2020-10-02 17:37 ` Guenter Roeck
2020-09-01 20:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901201910.GC143133@roeck-us.net \
--to=linux@roeck-us.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).