From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Linux PWM List <linux-pwm@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs
Date: Mon, 7 Sep 2020 08:09:58 +0200 [thread overview]
Message-ID: <20200907060958.GA4525@kozik-lap> (raw)
In-Reply-To: <CAL_Jsq+tGQhkqtQszOx7nvr1PR=YFz2p1=OnWQ8JxmSg4qNkHA@mail.gmail.com>
On Fri, Sep 04, 2020 at 04:36:39PM -0600, Rob Herring wrote:
> On Fri, Sep 4, 2020 at 9:25 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Driver requires different amount of clocks for different SoCs. Describe
> > these requirements properly to fix dtbs_check warnings like:
> >
> > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > ---
> >
> > Changes since v1:
> > 1. Do not require order of clocks (use pattern).
>
> To the extent that you can, you should fix the order in dts files
> first. If we just adjust the schemas to match the dts files, then
> what's the point?
The DTSes do not have mixed order of clocks between each other, as fair
as I remember. It was fix after Sasha Hauer comment that order is not
necessarily good.
We have the clock-names property, why enforcing the order?
>
> > ---
> > .../devicetree/bindings/mtd/gpmi-nand.yaml | 76 +++++++++++++++----
> > 1 file changed, 61 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > index 28ff8c581837..e08e0a50929e 100644
> > --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > @@ -9,9 +9,6 @@ title: Freescale General-Purpose Media Interface (GPMI) binding
> > maintainers:
> > - Han Xu <han.xu@nxp.com>
> >
> > -allOf:
> > - - $ref: "nand-controller.yaml"
> > -
> > description: |
> > The GPMI nand controller provides an interface to control the NAND
> > flash chips. The device tree may optionally contain sub-nodes
> > @@ -58,22 +55,10 @@ properties:
> > clocks:
> > minItems: 1
> > maxItems: 5
> > - items:
> > - - description: SoC gpmi io clock
> > - - description: SoC gpmi apb clock
> > - - description: SoC gpmi bch clock
> > - - description: SoC gpmi bch apb clock
> > - - description: SoC per1 bch clock
> >
> > clock-names:
> > minItems: 1
> > maxItems: 5
> > - items:
> > - - const: gpmi_io
> > - - const: gpmi_apb
> > - - const: gpmi_bch
> > - - const: gpmi_bch_apb
> > - - const: per1_bch
> >
> > fsl,use-minimum-ecc:
> > type: boolean
> > @@ -107,6 +92,67 @@ required:
> >
> > unevaluatedProperties: false
> >
> > +allOf:
> > + - $ref: "nand-controller.yaml"
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - fsl,imx23-gpmi-nand
> > + - fsl,imx28-gpmi-nand
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: SoC gpmi io clock
> > + clock-names:
> > + items:
> > + - const: gpmi_io
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - fsl,imx6q-gpmi-nand
> > + - fsl,imx6sx-gpmi-nand
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: SoC gpmi io clock
> > + - description: SoC gpmi apb clock
> > + - description: SoC gpmi bch clock
> > + - description: SoC gpmi bch apb clock
> > + - description: SoC per1 bch clock
> > + clock-names:
> > + items:
> > + - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
> > + - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
> > + - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
> > + - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
> > + - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
>
> BTW, you can make 'items' a schema rather than a list to apply a
> constraint to all entries:
>
> maxItems: 5
> items:
> pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
Right, I forgot about such syntax.
>
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx7d-gpmi-nand
> > + then:
> > + properties:
> > + clocks:
> > + items:
> > + - description: SoC gpmi io clock
> > + - description: SoC gpmi bch apb clock
> > + clock-names:
> > + minItems: 2
> > + maxItems: 2
>
> You can drop these. It's the default based on the size of 'items'.
Sure.
>
> > + items:
> > + - pattern: "^gpmi_(io|bch_apb)$"
> > + - pattern: "^gpmi_(io|bch_apb)$"
>
> Surely here we can define the order.
Yes, but still the same question as before - do we want the order? Why
enforcing it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-09-07 6:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:23 [PATCH v3 00/14] dt-bindings: Cleanup of i.MX 8 Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 01/14] dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 02/14] dt-bindings: pwm: imx-pwm: " Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 03/14] dt-bindings: serial: fsl-imx-uart: " Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 04/14] dt-bindings: serial: fsl-lpuart: Fix compatible matching Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 05/14] dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 06/14] dt-bindings: reset: fsl,imx7-src: " Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 07/14] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible Krzysztof Kozlowski
2020-09-19 11:48 ` Daniel Lezcano
2020-09-19 14:24 ` Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 08/14] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles Krzysztof Kozlowski
2020-09-04 15:23 ` [PATCH v3 09/14] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements Krzysztof Kozlowski
2020-09-04 15:24 ` [PATCH v3 10/14] dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching Krzysztof Kozlowski
2020-09-04 15:24 ` [PATCH v3 11/14] dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles Krzysztof Kozlowski
2020-09-04 15:24 ` [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs Krzysztof Kozlowski
2020-09-04 22:36 ` Rob Herring
2020-09-07 6:09 ` Krzysztof Kozlowski [this message]
2020-09-08 16:50 ` Rob Herring
2020-09-10 18:34 ` Krzysztof Kozlowski
2020-09-04 15:24 ` [PATCH v3 13/14] dt-bindings: mtd: nand-controller: Fix matching with size-cells==1 Krzysztof Kozlowski
2020-09-04 22:29 ` Rob Herring
2020-09-04 15:24 ` [PATCH v3 14/14] dt-bindings: clock: imx8m: Integrate duplicated i.MX 8M schemas Krzysztof Kozlowski
2020-09-14 22:53 ` [PATCH v3 00/14] dt-bindings: Cleanup of i.MX 8 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907060958.GA4525@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).