From: Lee Jones <lee.jones@linaro.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-power@fi.rohmeurope.com, linux-watchdog@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v8 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF
Date: Mon, 8 Mar 2021 13:36:14 +0000 [thread overview]
Message-ID: <20210308133614.GD4931@dell> (raw)
In-Reply-To: <560b9748094392493ebf7af11b6cc558776c4fd5.1613031055.git.matti.vaittinen@fi.rohmeurope.com>
On Thu, 11 Feb 2021, Matti Vaittinen wrote:
> Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
> mainly used to power the R-Car series processors.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Changes:
> - Comments fixed based on suggestions from Lee
> - Name of regulator cell changed as suggested by Lee
> - Renamed MFD cell variables for better readability
> - Aligned header definitions for better readability
>
> drivers/mfd/Kconfig | 11 ++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/rohm-bd9576.c | 109 +++++++++++++++++++++++++++++++
> include/linux/mfd/rohm-bd957x.h | 59 +++++++++++++++++
> include/linux/mfd/rohm-generic.h | 2 +
> 5 files changed, 182 insertions(+)
> create mode 100644 drivers/mfd/rohm-bd9576.c
> create mode 100644 include/linux/mfd/rohm-bd957x.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index bdfce7b15621..53c7c96283bd 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1998,6 +1998,17 @@ config MFD_ROHM_BD71828
> Also included is a Coulomb counter, a real-time clock (RTC), and
> a 32.768 kHz clock gate.
>
> +config MFD_ROHM_BD957XMUF
> + tristate "ROHM BD9576MUF and BD9573MUF Power Management ICs"
> + depends on I2C=y
> + depends on OF
> + select REGMAP_I2C
> + select MFD_CORE
> + help
> + Select this option to get support for the ROHM BD9576MUF and
> + BD9573MUF Power Management ICs. BD9576 and BD9573 are primarily
> + designed to be used to power R-Car series processors.
> +
> config MFD_STM32_LPTIMER
> tristate "Support for STM32 Low-Power Timer"
> depends on (ARCH_STM32 && OF) || COMPILE_TEST
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 14fdb188af02..e58fae024bb2 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -262,6 +262,7 @@ obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o
> obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o
> obj-$(CONFIG_MFD_ROHM_BD71828) += rohm-bd71828.o
> obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
> +obj-$(CONFIG_MFD_ROHM_BD957XMUF) += rohm-bd9576.o
> obj-$(CONFIG_MFD_STMFX) += stmfx.o
> obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o
>
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> new file mode 100644
> index 000000000000..efd439677c9e
> --- /dev/null
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2020 ROHM Semiconductors
If you get a chance, could you please update these?
> + * ROHM BD9576MUF and BD9573MUF PMIC driver
> + */
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-03-08 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 9:46 [PATCH v8 0/6] Support ROHM BD9576MUF and BD9573MUF PMICs Matti Vaittinen
2021-02-11 9:47 ` [PATCH v8 1/6] dt_bindings: mfd: Add " Matti Vaittinen
2021-02-11 9:48 ` [PATCH v8 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF Matti Vaittinen
2021-03-08 13:36 ` Lee Jones [this message]
2021-03-08 14:52 ` Matti Vaittinen
2021-02-11 9:48 ` [PATCH v8 3/6] mfd: bd9576: Add IRQ support Matti Vaittinen
2021-03-08 13:44 ` Lee Jones
2021-02-11 9:49 ` [PATCH v8 4/6] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF Matti Vaittinen
2021-02-11 9:49 ` [PATCH v8 5/6] MAINTAINERS: Add ROHM BD9576MUF and BD9573MUF drivers Matti Vaittinen
2021-02-11 9:50 ` [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring registers Matti Vaittinen
2021-03-08 13:47 ` Lee Jones
2021-03-08 15:09 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308133614.GD4931@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).