From: Guenter Roeck <linux@roeck-us.net>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Al Stone <al.stone@linaro.org>,
Jianchao Hu <hujianchao@hisilicon.com>,
Huiqiang Wang <wanghuiqiang@huawei.com>
Subject: Re: [PATCH] watchdog: sbsa: Support architecture version 1
Date: Mon, 10 May 2021 08:23:41 -0700 [thread overview]
Message-ID: <20210510152341.GA2704327@roeck-us.net> (raw)
In-Reply-To: <ec1bb835-3b53-4b17-1918-25975f4413a0@hisilicon.com>
On Mon, May 10, 2021 at 04:44:21PM +0800, Shaokun Zhang wrote:
> >>> +static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> >>
> >> What is the point of making val an u64 variable ? Without changing
> >
> > Oops, unsigned int is enough.
> >
>
> Sorry, it shall be 'u64', because it is the value that clock * timeout
> and will be written to WOR register which is 64-bit register in
> architecture version 1.
>
As I have been trying to point out, that won't really happen unless
max_hw_heartbeat_ms is adjusted. The register may be a 64 bit register,
and the variable may be a 64-bit variable, but that doesn't make the
value passed in that variable larger than 32 bit unless the code is
in place to actually do that.
Guenter
next prev parent reply other threads:[~2021-05-10 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 3:41 [PATCH] watchdog: sbsa: Support architecture version 1 Shaokun Zhang
2021-05-10 4:25 ` Guenter Roeck
2021-05-10 8:25 ` Shaokun Zhang
2021-05-10 8:44 ` Shaokun Zhang
2021-05-10 15:23 ` Guenter Roeck [this message]
2021-05-10 13:16 ` Guenter Roeck
2021-05-11 2:49 ` Shaokun Zhang
2021-05-11 3:52 ` Guenter Roeck
2021-05-11 6:03 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510152341.GA2704327@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=hujianchao@hisilicon.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wanghuiqiang@huawei.com \
--cc=wim@linux-watchdog.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).